feat(frontier): add optional relation field to RemovePlatformUserRequest#489
Merged
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Validate / validate (pull_request).
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIn Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
AmanGIT07
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional
relationfield (field number 3) toRemovePlatformUserRequestinraystack/frontier/v1beta1/admin.proto.Unlike the sibling
AddPlatformUserRequest.relation, this field is optional (notREQUIRED): an emptyrelationmust preserve today's behavior of removing the principal entirely.Why
This unblocks relation-selective platform-user removal in Frontier. Today Frontier's
RemovePlatformUserstrips both theadmin(superuser) andmember(check) platform relations because the request has norelationfield, so there is no way to demote an admin down to member or remove just one relation via the API.Adding this optional field lets callers target a single relation (
adminormember) while the empty default stays 100% backward compatible. It is a prerequisite for a declarative platform-user reconciler in Frontier, which must converge(principal, relation)pairs precisely. Frontier regenerates its Go stubs from this repo, so the field must land here first.Backward compatibility
proto3scalar field, additive only. Wire-compatible.buf lintandbuf formatpass.