Skip to content

fix: update entrypoint for optimus v0.2.1-rc.1#32

Merged
sbchaos merged 1 commit into
releases/v0.1.0from
fix-entrypoint
May 1, 2022
Merged

fix: update entrypoint for optimus v0.2.1-rc.1#32
sbchaos merged 1 commit into
releases/v0.1.0from
fix-entrypoint

Conversation

@deryrahman
Copy link
Copy Markdown
Member

@deryrahman deryrahman commented Apr 27, 2022

  • remove --with-server flag when execute optimus version
  • rename --project to --project-name

@deryrahman
Copy link
Copy Markdown
Member Author

follow up from changes raystack/optimus#274

@ravisuhag
Copy link
Copy Markdown
Member

@deryrahman IMO, project is more user friendly than project-name. WDYT?

@deryrahman
Copy link
Copy Markdown
Member Author

deryrahman commented Apr 28, 2022

@ravisuhag yes, but I think --project-name is also convenient. As of now, flags-to-override-config follows the conventions from config structure. so, the config:

project:
    name:

will be match with flag --project-name. Making it to --project requires effort, since the flags is automapped by flags-to-config bindings

@ravisuhag
Copy link
Copy Markdown
Member

ravisuhag commented Apr 28, 2022

@deryrahman User experience is more important than effort IMO. Also, it was already project, so why are changing it now?

@deryrahman
Copy link
Copy Markdown
Member Author

@ravisuhag noted, agree, new lesson for me. Actually, we change it to make it consistent with convention in config structure. But, sure, I think we can provide flag --project back(?) wdyt @sravankorumilli

@sbchaos sbchaos merged commit 15469ee into releases/v0.1.0 May 1, 2022
@sbchaos sbchaos deleted the fix-entrypoint branch May 1, 2022 03:51
sravankorumilli added a commit that referenced this pull request May 11, 2022
* build: release plugins with optimus version 0.2.1-rc.1

* fix: update entrypoint for optimus v0.2.1-rc.1 (#32)

* release: upgrade to optimus v0.2.0-alpha

Co-authored-by: Dery Rahman Ahaddienata <dery.ra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants