revert: median concurrency changes #1213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashish10677
previously approved these changes
May 30, 2024
ashish10677
approved these changes
Jun 13, 2024
rajkharvar
approved these changes
Jun 13, 2024
Yashk767
added a commit
to Yashk767/razor-go
that referenced
this pull request
Jul 19, 2024
* Revert "refactor: storing medians concurrently (razor-network#1172)" This reverts commit 230a971. * Revert "refactor: optimized GetSortedRevealedValues (razor-network#1173)" This reverts commit 9842a61. * fix: fixed API tests by updating RPC provider to op sepolia staging in POST request tests * refactor: rewritten tests extensively for GetSortedRevealedValues() * Revert "fix: Increased the buffer size of errChan in `GetBiggestStakerId` (razor-network#1175)" This reverts commit 99de721. * Revert "refactor: biggest staker calculation implemented using goroutines (razor-network#1171)" This reverts commit ef41b96.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts:
GetSortedRevealedValuesrefactor: optimized GetSortedRevealedValues #1173GetBiggestStakerAndIdrefactor: biggest staker calculation implemented using goroutines #1171 fix: Increased the buffer size of errChan inGetBiggestStakerId#1175This PR also Tests
GetSortedRevealedValues()extensively with accurate data.