Conversation
.github/workflows/prod_ci.yml
Outdated
There was a problem hiding this comment.
This will be hitting prod right? Please disable it or remove it from the PR if it is not needed.
There was a problem hiding this comment.
These will not be going on prod. i am going to remove these e2e and share this file in slack
e2e/resources/tests.js
Outdated
There was a problem hiding this comment.
Remove this from the PR. Please share this file in the Slack thread
e2e/razorpay.js
Outdated
There was a problem hiding this comment.
Remove this as well since we are yet to figure out on e2e approach
There was a problem hiding this comment.
Yes for testing purposes I added this . will remove before merge
lib/api.js
Outdated
| } | ||
|
|
||
| postBody(params, cb) { | ||
| postformData(params, cb){ |
There was a problem hiding this comment.
Suggestion : Can rename to postFormData
lib/api.js
Outdated
| } | ||
|
|
||
| postBody(params, cb) { | ||
| postformData(params, cb){ |
There was a problem hiding this comment.
Write a comment that this has been used when uploading files
…ay-node into refactor/encoded-to-body
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
==========================================
- Coverage 91.41% 89.95% -1.47%
==========================================
Files 27 27
Lines 1072 906 -166
==========================================
- Hits 980 815 -165
+ Misses 92 91 -1
|
lib/types/orders.d.ts
Outdated
| } | ||
| } | ||
|
|
||
| interface ConvenienceFeeConfig { |
There was a problem hiding this comment.
Why is this getting included in this PR? Does this have any relation with changing content-type to application-json @ankitdas13
1995navinkumar
left a comment
1995navinkumar
left a comment
There was a problem hiding this comment.
LGTM. Please test it thoroughly before releasing
ankitdas13
added
Tested
TestingNotRequired
3 participants
Improvement: Change Encoded Type to Request Body
post,put&patchmethod & replace encoded type fromformtobodyNote : Tested all Api's from my end , let me know we you want to test all api's in workflow then i will setup.