Crashes on lsp-mode with version 0.5.4

[joefbkohler]

After updating to 0.5.4 csharp-ls crashes not long after initialization.

I don't know where to get a log, so if you need one please tell me where I can find it. The only error I get in stderr is Process csharp-ls stderr<1> finished

It crashes while moving the cursor, so my suspicion are either highlight or documentation.

[razzmatazz]

hey; I am tripping on this as well, debugging why -- will release a new version asap

[joefbkohler]

Let me know if I can help.

[razzmatazz]

the cause is apparently this:

• ionide/LanguageServerProtocol@114bd9c

I am just trying to find a a way to avoid reverting this on the upstream and just fix csharp-ls with try/with in right places :)

[razzmatazz]

I have added this commit: 0641128 but not 100% that fixes it all

[razzmatazz]

@joefbsjr if you could test if the fix works for you then it would be really nice

because it does not hit it for me at once, it takes some incantation of requests to trigger the crash.. for some reason, so I am reluctant to declare victory yet :)

[joefbkohler]

Sure. Will try later today.

[razzmatazz]

uh.. actually the error seems to be in upstream Ionide.LSP -- it marks LocalRpcException as fatal, but at the same time it uses it to report "error" lsp results.. ok, attempt no 2 at fixing this

[razzmatazz]

lets see if abdc323 helps

[razzmatazz]

Upstream Ionide.LSP PR:

• Avoid server crash when handler returns LspResult.Error ionide/LanguageServerProtocol#33

[razzmatazz]

0.5.5 released that should fix this (I very much hope so):

• https://www.nuget.org/packages/csharp-ls/0.5.5

[razzmatazz]

Closing, @joefbsjr please reopen if this occurs again