aria2c doesn't support writing remote content to stdout#965
Merged
mislav merged 5 commits intorbenv:masterfrom Aug 12, 2016
Merged
aria2c doesn't support writing remote content to stdout#965mislav merged 5 commits intorbenv:masterfrom
aria2c doesn't support writing remote content to stdout#965mislav merged 5 commits intorbenv:masterfrom
Conversation
Member
|
Thanks for catching this. Like my comment in #904 (comment), I don't like that every tweak to aria2c support needs to touch all tests. Is there a way we can circumvent this? Maybe go back to stubbing |
Contributor
Author
|
It sounds nicer than current test impl..... I'll try to do it later. |
9feae21 to
63e76cc
Compare
Contributor
Author
|
I've prepared test helper to remove @mislav could you review the changes again? |
yyuu
added a commit
to pyenv/pyenv
that referenced
this pull request
Jun 21, 2016
Member
|
Thanks for doing all the work and being patient! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've implemented
aria2csupport in #904. However, I finally realized thataria2cdoesn't support writing remote content to stdout (aria2/aria2#190).I confirmed that basically this must be not a problem for ruby-build since it doesn't rely on
http getwithout filename (the only usage of http get is specifying its destination filename). It'd be better to be fixed though.