Skip to content

Documentation fixes#54

Closed
MeanSquaredError wants to merge 2 commits intorbock:mainfrom
MeanSquaredError:doc_fixes
Closed

Documentation fixes#54
MeanSquaredError wants to merge 2 commits intorbock:mainfrom
MeanSquaredError:doc_fixes

Conversation

@MeanSquaredError
Copy link
Copy Markdown
Contributor

This PR documents the changes in the in the ddl2cpp options that were introduced recently. It also fixes a link in the todo document, that points to a discussion about sync support.

| `operator+=` etc | `x += y` was translated into `x = x + y` | *no magic* |
| aggregate functions | auto-named in `select` but not otherwise | require explicit names, e.g. max(id).as(sqlpp::alias::max_) |
| | | |
| **ddl2cpp** | | |
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Changes beyond the .66 release are documented in documented in docs/change_log.md

Maybe that should be organized better?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. Maybe I should just drop the PR then?

rbock added a commit that referenced this pull request Aug 22, 2025
rbock added a commit that referenced this pull request Aug 22, 2025
@rbock
Copy link
Copy Markdown
Owner

rbock commented Aug 22, 2025

Please see https://github.com/rbock/sqlpp23/blob/develop/docs/change_log.md#066

Is that less confusing than before?

@MeanSquaredError
Copy link
Copy Markdown
Contributor Author

MeanSquaredError commented Aug 22, 2025

@rbock
I think it is better to keep differences_to_sqlpp11.md as a separate document (like it was before), because IMHO currently more people are interested in migration from sqlpp11 to sqlpp23, than in the changes between different versions of sqlpp23. So it makes sense for the users to have differences_to_sqlpp11.md as a separate file, I think that having the differences placed in the changelog makes it more difficult for the migrating user to find them.

What makes sense is probably expanding the document ddl2cpp.md and describing the different command-line switches of the program.

@rbock
Copy link
Copy Markdown
Owner

rbock commented Aug 22, 2025

Thanks for the feedback. I'll undo the changes.

Closing this PR.

@rbock rbock closed this Aug 22, 2025
@MeanSquaredError MeanSquaredError deleted the doc_fixes branch August 26, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants