When installing also install the module (.cppm) files#58
Merged
rbock merged 3 commits intorbock:mainfrom Aug 29, 2025
Merged
Conversation
MeanSquaredError
force-pushed
the
install_modules
branch
from
0c04920 to
bcb7cd2
Compare
Contributor
Author
|
It seems that the build error is caused by some kind of AppVeyor time limit |
Owner
Yeah, it happened the first time with a documentation change a week or two ago. It might force us to reduce the number of tests to compile. |
Owner
|
Thanks for the cleanup and the installation rules! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing the library, the relevant module (.cppm) files were not copied along with the header files. This PR fixes this issue and closes #57