Skip to content

Upgrade Puppeteer from v5.5.0 to v22.0.0 for ARM64 support#290

Merged
rbren merged 2 commits intomasterfrom
upgrade-puppeteer
Jan 14, 2026
Merged

Upgrade Puppeteer from v5.5.0 to v22.0.0 for ARM64 support#290
rbren merged 2 commits intomasterfrom
upgrade-puppeteer

Conversation

@rbren
Copy link
Copy Markdown
Owner

@rbren rbren commented Jan 14, 2026

  • Fixes browser test failures on Apple Silicon (ARM64) architecture
  • Modern Puppeteer v22 has native ARM64 support with Chrome for Testing
  • All 38 tests now passing (including 2 previously failing browser tests)
  • Removes need for manual Chromium installation or workarounds

- Fixes browser test failures on Apple Silicon (ARM64) architecture
- Modern Puppeteer v22 has native ARM64 support with Chrome for Testing
- All 38 tests now passing (including 2 previously failing browser tests)
- Removes need for manual Chromium installation or workarounds
@rbren
Copy link
Copy Markdown
Owner Author

rbren commented Jan 14, 2026

@OpenHands diagnose and fix the test issues on github actions

@openhands-ai
Copy link
Copy Markdown

openhands-ai bot commented Jan 14, 2026

I'm on it! rbren can track my progress at all-hands.dev

@openhands-ai
Copy link
Copy Markdown

openhands-ai bot commented Jan 14, 2026

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • tests
    • tests

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #290 at branch `upgrade-puppeteer`

Feel free to include any additional details that might help me get this PR into a better state.

You can manage your notification settings

- Update GitHub Actions workflow to test on Node.js 18.x, 20.x, 22.x
- Add engines field to package.json specifying Node.js >=18 requirement
- Puppeteer v22 requires Node.js 18+, so older versions are no longer supported
- Fixes CI failures caused by lockfileVersion 3 incompatibility with npm 6.x
@openhands-ai
Copy link
Copy Markdown

openhands-ai bot commented Jan 14, 2026

Summary

I diagnosed and fixed the GitHub Actions test failures for PR #290.

Root Cause

The CI was failing because:

  1. Puppeteer v22 requires Node.js 18+ - The PR upgraded Puppeteer from v5.5.0 to v22.0.0, but the CI workflow was still testing on Node.js 14.x and 16.x
  2. lockfileVersion incompatibility - The package-lock.json uses lockfileVersion 3 (npm 9+), which is incompatible with npm 6.x bundled with Node.js 14

Changes Made

  1. Updated .github/workflows/node.js.yml: Changed the Node.js version matrix from [14.x, 16.x, 18.x] to [18.x, 20.x, 22.x] with a comment explaining the Puppeteer v22 requirement

  2. Updated package.json: Added an engines field specifying "node": ">=18" to document the Node.js requirement

Result

All CI jobs now pass:

  • ✅ Node.js 18.x - success
  • ✅ Node.js 20.x - success
  • ✅ Node.js 22.x - success

The changes have been pushed to the upgrade-puppeteer branch and the PR is now ready for review.

View full conversation

@rbren rbren merged commit 425599f into master Jan 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants