Sort cards before state update

[belgamo]

When I needed to use the laneSortFunction I notice that it's work fine in a single lane as showed in the story example. But there's a bug when I have more than one lane. The react-trello gets confused with the new indexes and consequently move wrong cards on dragging and dropping.

I fixed the issue by reordering the cards before they were added on the lane.

[dapi]

@belgamo hi!

Thank you very much for such detailed PR!

I pulled this branch and have played with some stories and found that basic scenario with card dragging does not work as it expected.

Here is sample - http://g.recordit.co/DjFi6MNr34.gif

[dapi]

Probably we need to disable card dragging when laneSortFunction is used? What do you think?

[belgamo]

@dapi Hi!

I think your comment #337 (comment) makes sense! However, the problem occurs because this line changes the original cards and this influences their order even when the laneSortFunction is not used. I suggest the code bellow:

if (laneSortFunction) {
  let cardsToUpdate = [...lane.cards, ...newCards]
  cardsToUpdate.sort(laneSortFunction)

  return update(lane, {cards: {$set: cardsToUpdate}})
}

return update(lane, {cards: {$splice: [[index, 0, ...newCards]]}})

What do you think?

[dapi]

Hi @belgamo!

What is you use case to sort cards? Do you save these cards to backend? Does it sort on backend also?

Pay attention to there are event bus and we need to emit MOVE_CARD event to every moved card if it is resorted.

I think the better way to give possibility to customise appendCardsToLane function using dependency injection.

[dapi]

One more thought. Can we use event MOVE_CARD to catch this moment and resort cards as we want?

[orangecoding]

Hey guys. what's the status on this? I just spend like 2 hours to track this problem down until I found that somebody already did it... 😱
Any eta when we can expect an update?

[LucasBadico]

Guys this solution is not working. Seen the same thing. I have just merged with the v2.2.8 and is the same as before.

[dapi]

either respect event bus and emit event for resorted cards or use dependency injection to customise appendCardsToLane