Merged
Conversation
Had to fix LineParser to be compatible with version 2.4.0
TableParser: in doParseRows: we no longer convert an iterator into a sequence.
RowParser: Reversed the order of parameter sets in.parse method; TableParser#AbstractTableParser: changed definition of function f in doParseRows;
InputTransformer: new abstract class; TableParser: use InputTransformer in doParseRows.
IndexedInputToTableTransformer: new concrete class (was an anonymous inner class);
TableParser: * added process and doProcessRows; * fixed a little issue (not flagged) with shadowing Input type; Other essentially cosmetic changes, some to fix Codacy issues.
InputTransformer: * renamed InputTransformer as InputAggregator; * added InputTransformer; * added concrete classes for these types; RowProcessor: added; Table: sourceFromFilename/ClassResource methods have been made public; Movie: added MovieRowProcessor; TableParser: cosmetics.
In InputTransformer classes, changed the definition of function f to have the header built-in, so to speak.
RowParser: changed name of parse method to parseIndexed; added parse method.
WARNING need to check if this really does work with DatasetMapper because I did some tinkering.
Some cosmetics
Mostly non-functional changes
Created a separate module for DailyRaptorReport; With updates to README.md;
However, running the equivalent unit test in the DatasetMapperSpec is not successful.
README.md: updates; TableParser: * renamed maybeFixedHeader to maybeHeader; * unprotected rowParser; * made default n for parse(Iterator,Int) equal to headerRowsToRead; * added abstract class HeadedCSVTableParser; Movie: now uses HeadedCSVTableParser;
TableParser: maybeHeader now has a default value of None.
Content: added an apply method that takes an Iterator;
Owner
Author
|
Renamed this version as 1.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.