Synopsis
Currently --max-delete in bisync has syntax different from the rest of rclone - it means a percentage. Instead, it should have an optional trailing % sign like --max-delete 50% to mean the maximum share of deleted files. Without % it should set a maximum number of the total number of files deleted rather than a percentage like the rest of rclone. The default should stay as is i.e. 50%. This behavior should be retained in the bisync rc handler.
We could later implement the % trick in the rest of rclone too (out of scope for this request).
Prior discussions
#5164 (comment)
iva: I made bisync use the generic --max-delete flag but as a percentage in range 0..100 rather than absolute number of deleted objects. Maybe it's better to rename it as --max-delete-percent or --bisync-max-delete?
ncw: I think --max-delete should probably set a maximum of the total number of files deleted rather than a percentage. Could you use it that way in bisync? Maybe it could have an optional trailing % sign so --max-delete 5% and we could implement that in the rest of rclone too.
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Synopsis
Currently
--max-deletein bisync has syntax different from the rest of rclone - it means a percentage. Instead, it should have an optional trailing%sign like--max-delete 50%to mean the maximum share of deleted files. Without%it should set a maximum number of the total number of files deleted rather than a percentage like the rest of rclone. The default should stay as is i.e.50%. This behavior should be retained in the bisyncrchandler.We could later implement the
%trick in the rest of rclone too (out of scope for this request).Prior discussions
#5164 (comment)
iva: I made bisync use the generic
--max-deleteflag but as a percentage in range0..100rather than absolute number of deleted objects. Maybe it's better to rename it as--max-delete-percentor--bisync-max-delete?ncw: I think
--max-deleteshould probably set a maximum of the total number of files deleted rather than a percentage. Could you use it that way inbisync? Maybe it could have an optional trailing%sign so--max-delete 5%and we could implement that in the rest of rclone too.How to use GitHub