local: Evaluate symlinks for remote root path#6014
Open
danbeibei wants to merge 1 commit intorclone:masterfrom
Open
local: Evaluate symlinks for remote root path#6014danbeibei wants to merge 1 commit intorclone:masterfrom
danbeibei wants to merge 1 commit intorclone:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Using the move command to a destination directory which happens to be the source directory but not with the same path (with use of symlinks) results in directory content removal. The purpose is to prevent user error by detecting that source and destination are actually the same in this particular scenario.
Change description
Evaluate symlinks for the root path of local remote:
rclone already checks if the canonicalised root path are the same, this change add sylmlinks evaluation to the canonicalisation of root paths.
Was the change discussed in an issue or in the forum before?
https://forum.rclone.org/t/more-foolproof-move-command-destination-is-symlink-pointing-to-source/29468
Checklist