fs/config: Read configuration password from EOFed stdin - fixes #8480#8481
Merged
ncw merged 1 commit intorclone:masterfrom Apr 9, 2025
Merged
fs/config: Read configuration password from EOFed stdin - fixes #8480#8481ncw merged 1 commit intorclone:masterfrom
ncw merged 1 commit intorclone:masterfrom
Conversation
…ed with EOF - fixes rclone#8480
ncw
approved these changes
Apr 9, 2025
Member
ncw
left a comment
ncw
left a comment
There was a problem hiding this comment.
This looks great - thank you. A nice fix of a Go gotcha. Will merge now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
This change fixes #8480. When reading the configuration password from stdin, the original behavior of Rclone was to throw an error if the stream hit EOF before encountering a line break even if a password was provided. This change would ignore the EOF as long as the read string is not empty.
Was the change discussed in an issue or in the forum before?
The issue #8480 presents the root cause and mentions proposed change, but no discussion has occurred yet.
Checklist