Skip to content

Call thread.start should check status of the process #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2020
Merged

Call thread.start should check status of the process #47

merged 2 commits into from
May 24, 2020

Conversation

@benpigchu
Copy link
Contributor

@benpigchu benpigchu commented May 24, 2020

The thread.start syscall should fail when the process status is not Running. Also, the proc.start syscall should call proc.start instead of thread.start, which sets process status to Running.
After this PR, the Threads.ThreadStartOnInitialThread test should pass.

benpigchu added 2 commits May 24, 2020 20:20
@benpigchu
Call proc.start when proc.start
4c317ac 
also check proc status when thread start
@benpigchu
fix test
206a9e6
@coveralls
Copy link

coveralls commented May 24, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 113911188

  • 0 of 16 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.7%) to 24.127%
Changes Missing Coverage Covered Lines Changed/Added Lines %
zircon-syscall/src/task.rs 0 6 0.0%
zircon-object/src/task/process.rs 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-channel-0.3.5/src/oneshot.rs 1 0%
zircon-syscall/src/task.rs 1 0%
Totals Coverage Status
Change from base Build 111313309: 0.7%
Covered Lines: 2011
Relevant Lines: 8335
💛 - Coveralls

@wangrunji0408 wangrunji0408 merged commit ccf348b into rcore-os:master May 24, 2020
@wangrunji0408 wangrunji0408 added the bug Something isn't working label Jun 18, 2020
zhangsn-19 pushed a commit to zhangsn-19/zCore that referenced this pull request Apr 23, 2022
@benpigchu
Call thread.start should check status of the process (rcore-os#47)
270f902 
* Call proc.start when proc.start
also check proc status when thread start

* fix test
@coveralls
Copy link

coveralls commented Jul 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 113911188

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 16 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.7%) to 24.127%
Changes Missing Coverage Covered Lines Changed/Added Lines %
zircon-syscall/src/task.rs 0 6 0.0%
zircon-object/src/task/process.rs 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-channel-0.3.5/src/oneshot.rs 1 0.0%
zircon-syscall/src/task.rs 1 0.0%
Totals Coverage Status
Change from base Build 111313309: 0.7%
Covered Lines: 2011
Relevant Lines: 8335
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangrunji0408 wangrunji0408 wangrunji0408 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benpigchu @coveralls @wangrunji0408