Fix segmentation fault with -march=native #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@danpf Let me know if the changes look ok. Also I will need an approved review to merge this to master... ;-) |
danpf
approved these changes
Oct 22, 2020
Collaborator
danpf
left a comment
danpf
left a comment
There was a problem hiding this comment.
this looks good to me! thanks @gtauriello !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took over fix for #36 and modifications for Travis CI from #35 .
Important note: I had to add
set -eto the bash script (build_and_run_tests.sh) which runs the test since otherwise a failing test wouldn't trigger a failure in CI.