-
Notifications
You must be signed in to change notification settings - Fork 141
Use rdf-test-suite for spec testing #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rdf-test-suite for spec testing #155
Conversation
|
Thanks, will look at failing tests! |
|
@rubensworks I'm also seeing blank node failures: https://travis-ci.org/rdfjs/N3.js/jobs/463382092#L2778 |
|
Yeah, those tests are wrong. Fixed them in w3c/rdf-tests#53. |
|
FYI, w3c/rdf-tests#53 has been merged, so the 3 tests mentioned above are the only ones failing now. |
|
Thanks! Actually, only 2 are failing now: turtle-subm-01 and turtle-subm-27. The first one seems a false negative, the second one still seems base IRI-related. What do you make of it? |
|
Ah, you'll have to clear the Travis cache first, because I enabled caching for all fetched resources. (I can disable caching again if you prefer that) And regarding the test output, it looks like bash is short-circuiting the first failure: Line 38 in 2a9b62d
So I'll have to come up with a better system for that... |
b3ea431 to
d45e1ff
Compare
|
Changed things around a bit. All spec tests will now run, even if the previous ones failed. The Travis cache has to be cleared for this build in order to get the updated tests (w3c/rdf-tests#53). (You'll have to do this, as I don't have permissions for this) |
Pull Request Test Coverage Report for Build 537
💛 - Coveralls |
|
@rubensworks Thanks so much! |
Note: this is blocked by: w3c/rdf-tests#53
As described in #154, this uses rdf-test-suite for spec testing.
Advantages:
Discovered 3 failing tests, so the Travis build fails because of this: