Skip to content

Conversation

@rubensworks
Copy link
Member

Note: this is blocked by: w3c/rdf-tests#53

As described in #154, this uses rdf-test-suite for spec testing.

Advantages:

  • Fix spec compliance not being tested anymore
  • Removal of SWObjects as a (dev) dependency
  • Uses the more up-to-date test suites from RDF Test Curation Community Group.

Discovered 3 failing tests, so the Travis build fails because of this:

✖ nt-syntax-bad-string-04
  long single string literal (negative test)
  Error: Expected to throw an error when parsing.
  Query: <http://example/s> <http://example/p> '''abc''' .


  More info: http://w3c.github.io/rdf-tests/nquads/manifest.ttl#nt-syntax-bad-string-04


✖ nt-syntax-bad-string-05
  long double string literal (negative test)
  Error: Expected to throw an error when parsing.
  Query: <http://example/s> <http://example/p> """abc""" .


  More info: http://w3c.github.io/rdf-tests/nquads/manifest.ttl#nt-syntax-bad-string-05

✖ sole_blankNodePropertyList
  sole blankNodePropertyList [ <p> <o> ] .
  Error: Unexpected } on line 3.
  More info: http://w3c.github.io/rdf-tests/trig/manifest.ttl#sole_blankNodePropertyList

@RubenVerborgh
Copy link
Member

Thanks, will look at failing tests!

@RubenVerborgh
Copy link
Member

@rubensworks I'm also seeing blank node failures: https://travis-ci.org/rdfjs/N3.js/jobs/463382092#L2778

@rubensworks
Copy link
Member Author

Yeah, those tests are wrong. Fixed them in w3c/rdf-tests#53.

@rubensworks
Copy link
Member Author

FYI, w3c/rdf-tests#53 has been merged, so the 3 tests mentioned above are the only ones failing now.

@RubenVerborgh
Copy link
Member

Thanks! Actually, only 2 are failing now: turtle-subm-01 and turtle-subm-27. The first one seems a false negative, the second one still seems base IRI-related. What do you make of it?

@rubensworks
Copy link
Member Author

Ah, you'll have to clear the Travis cache first, because I enabled caching for all fetched resources. (I can disable caching again if you prefer that)

And regarding the test output, it looks like bash is short-circuiting the first failure:

"spec": "npm run spec-turtle && npm run spec-ntriples && npm run spec-nquads && npm run spec-trig",

So I'll have to come up with a better system for that...

@rubensworks rubensworks force-pushed the feature/rdf-test-suite branch 2 times, most recently from b3ea431 to d45e1ff Compare December 6, 2018 09:22
@rubensworks
Copy link
Member Author

Changed things around a bit.

All spec tests will now run, even if the previous ones failed.
Also, Travis will fail once at least one of the spec tests fails.

The Travis cache has to be cleared for this build in order to get the updated tests (w3c/rdf-tests#53). (You'll have to do this, as I don't have permissions for this)

@coveralls
Copy link

coveralls commented Dec 8, 2018

Pull Request Test Coverage Report for Build 537

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 529: 0.0%
Covered Lines: 1261
Relevant Lines: 1261

💛 - Coveralls

@RubenVerborgh RubenVerborgh merged commit 49b9f57 into rdfjs:master Dec 10, 2018
@RubenVerborgh RubenVerborgh deleted the feature/rdf-test-suite branch December 10, 2018 22:44
@RubenVerborgh
Copy link
Member

@rubensworks Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants