Skip to content

Do not display an UIAlertView on authentication failure #30

Description

@xinsight

While authenticating a user token, if there is a failure (e.g. no network) an UIAlertView is displayed.

There is no way to prevent this alertview from appearing, and it is also not particularly helpful (Error: Login failed). Why did it fail? How do they know it relates to Rdio?

The rdioAuthorizationFailed delegate is still called, so you can ditch the alertview and let application developers to handle the error in a more useful way.

(ps - Better separation of model and views would greatly improve the utility of the SDK. It would be so much cleaner to simply check the rdio authentication status and then display the RDAuthViewController if and when it makes sense.)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions