update esformatter to ~0.3.2 #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm ok with upgrading it. How does the styleguide look when formatted? Any diff? |
Contributor
|
Nice! The update fixes several of the styleguide TODOs. EDIT: https://gist.github.com/jimfleming/fa839432839179b7ad13 |
Contributor
Author
|
@jimfleming nice it seems like they fixed some continuation stuff. not sure I have a really strong opinion on how they should be, but I can update the style guide with this PR. |
Contributor
|
Yah, that would be great (just so that there's no diff). |
Contributor
Author
|
@jimfleming updated with all new formatted js files, just waiting on travis then should be good? |
jimfleming
added a commit
that referenced
this pull request
Jun 25, 2014
update esformatter to ~0.3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just had an issue with the way it was formatting the json in the one test, but other than that all the tests pass locally for me.
any concerns with upgrading this?