WebGLShader VertexAttribPointerOffset wrong index ?

[hacketo]

Hi,
I have an issue using the OutlineShader, I found that since commit e16ae52 it does not work properly.
I updated the WebGLShader to correct a possible miss in that commit, see 7e3c276 .
Does this make sense ?

[g-zachar]

Hi @hacketo,

Can you give a bit of description of what you see as a problem in OutlineShader's behaviour? Also, thanks for contributing.

Best regards

[hacketo]

Before and after the 'cleanup' commit

My commit make it work again, it seem that the offset is off and impact other shaders. But i'm no expert about WebGL.

Best regards

[g-zachar]

Hi @hacketo,

Very nice find. It turns Dithering and Pixelate shaders were also broken for some time and unnoticed. The change is correct and the fix will be in next release. Thanks a lot for contributing!

Best regards