Corrected bug on resizeMode When using an already loaded textureSourc… #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacketo
force-pushed
the
resizeModeTextureSource
branch
from
560ebd3 to
8cf3714
Compare
g-zachar
suggested changes
Jan 31, 2020
Contributor
g-zachar
left a comment
g-zachar
left a comment
There was a problem hiding this comment.
Hi @hacketo ,
thanks for contributing. There was already one issue with resizeMode and one test related to it (under textures/load/regression, so the only thing I can see improved in this PR is moving your test there.
Best regards
hacketo
force-pushed
the
resizeModeTextureSource
branch
from
8cf3714 to
a132300
Compare
…e, the resizeMode was not applied to the Texture itself
hacketo
force-pushed
the
resizeModeTextureSource
branch
from
a132300 to
be1a325
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is proposed patch for issue #103