Conversation
Vinodsathyaseelan
force-pushed
the
RPPL-993
branch
from
79b3b21 to
f59a3ba
Compare
satlead
approved these changes
Dec 12, 2023
B-Larsen
approved these changes
Jan 5, 2024
brendanobra
pushed a commit
to brendanobra/Ripple
that referenced
this pull request
Feb 2, 2025
Co-authored-by: Ndelle432 <ndelle432>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Metrics.Action Call Optimization by caching privacy settings values
Why
It has been noticed that certain apps are making excessive Metrics.Action calls on certain scenarios.
This API internally invokes multiple extension send request to collect different privacy settings values from storage extension as well as communicating to various distributor servers.
All these operations are impacting the performance of Metrics.Action call and it was taking an average 100ms to return a response to the caller.
By changing some of the extension send request to 'fire and forget' call and caching the privacy settings in ripple core, we are able to reduce the total API response time to under 6ms.
How
How do these changes achieve the goal?
Test
How has this been tested? How can a reviewer test it?
Checklist