Update discovery launch include age policy#885
Merged
maggie98choy merged 8 commits intomainfrom Sep 3, 2025
Merged
Conversation
implement account.policyIdentifierAlias extension API update discovery.launch to includes age policy field in intent
| impl PolicyState { | ||
| pub async fn add_policy_identifier_alias(&mut self, policy: PolicyIdentifierAlias) { | ||
| let mut policy_identifiers_alias = self.policy_identifiers_alias.write().unwrap(); | ||
| if policy.policy_identifier_alias.is_empty() { |
Contributor
There was a problem hiding this comment.
The usage of same member field name policy_identifier_alias in both policy and PolicyState are confusing. Use different field names.
Vinodsathyaseelan
approved these changes
Aug 27, 2025
dhillomk
approved these changes
Sep 3, 2025
Minimum allowed line rate is |
kvfasil
added a commit
that referenced
this pull request
Jan 30, 2026
brendanobra
pushed a commit
that referenced
this pull request
Feb 6, 2026
…d(8.1). (#941) * Backporting discovery.lauch() changes. * Share_watch_history api added. * Share_watch_history api added. * Share_watch_history Request enum created. * picked some childpolicy chnages #885. * code clean up. * Updated log info Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Updated session handling. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Removed intent update. * Feat: added http POST support. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
What does this PR add or remove?
Why
Why are these changes needed?
How
How do these changes achieve the goal?
Test
How has this been tested? How can a reviewer test it?
Checklist