Skip to content

Update discovery launch include age policy#885

Merged
maggie98choy merged 8 commits intomainfrom
update-discovery-launch-include_age_policy
Sep 3, 2025
Merged

Update discovery launch include age policy#885
maggie98choy merged 8 commits intomainfrom
update-discovery-launch-include_age_policy

Conversation

@maggie98choy
Copy link
Contributor

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

implement account.policyIdentifierAlias extension API

update discovery.launch to includes age policy field in intent
impl PolicyState {
pub async fn add_policy_identifier_alias(&mut self, policy: PolicyIdentifierAlias) {
let mut policy_identifiers_alias = self.policy_identifiers_alias.write().unwrap();
if policy.policy_identifier_alias.is_empty() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage of same member field name policy_identifier_alias in both policy and PolicyState are confusing. Use different field names.

@github-actions
Copy link

github-actions bot commented Sep 3, 2025

Code Coverage

Package Line Rate Health
core.main.src.state.cap 43%
core.sdk.src.manifest 0%
core.main.src.state 36%
core.sdk.src.api.device 77%
core.sdk.src.api.firebolt 77%
core.sdk.src.service 19%
core.sdk.src.utils 61%
core.main.src.broker.thunder 37%
core.tdk.src.gateway 100%
device.mock_device.src 55%
core.sdk.src.api.distributor 68%
device.thunder_ripple_sdk.src.client 67%
core.main.src.firebolt 2%
core.sdk.src.api 46%
core.tdk.src.utils 0%
core.main.src 0%
core.main.src.utils 30%
device.thunder_ripple_sdk.src.processors.events 0%
core.main.src.service.extn 25%
device.thunder_ripple_sdk.src.bootstrap 0%
core.main.src.bootstrap.extn 0%
device.thunder_ripple_sdk.src.events 4%
device.thunder_ripple_sdk.src 17%
core.main.src.service.ripple_service 7%
core.main.src.processor 0%
core.main.src.service.apps 25%
core.main.src.processor.storage 0%
core.sdk.src.processor 4%
core.main.src.broker.rules 78%
core.main.src.firebolt.handlers 12%
core.sdk.src.api.observability 57%
device.thunder_ripple_sdk.src.processors 17%
core.sdk.src.extn 77%
core.main.src.bootstrap.manifest 0%
core.main.src.service 35%
core.sdk.src.framework 64%
core.sdk.src.api.manifest 75%
core.sdk.src.service.mock_app_gw.appgw 0%
core.sdk.src.service.mock_app_gw 0%
core.sdk.src.extn.ffi 0%
core.main.src.broker.test 90%
core.main.src.broker 70%
core.sdk.src.extn.client 82%
core.sdk.src.api.gateway 69%
core.main.src.bootstrap 0%
Summary 48% (20396 / 42668)

Minimum allowed line rate is 46%

@maggie98choy maggie98choy merged commit 3e392e3 into main Sep 3, 2025
10 checks passed
@maggie98choy maggie98choy deleted the update-discovery-launch-include_age_policy branch September 3, 2025 19:22
kvfasil added a commit that referenced this pull request Jan 30, 2026
brendanobra pushed a commit that referenced this pull request Feb 6, 2026
…d(8.1). (#941)

* Backporting discovery.lauch() changes.

* Share_watch_history api added.

* Share_watch_history api added.

* Share_watch_history Request enum created.

* picked some childpolicy chnages #885.

* code clean up.

* Updated log info

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Updated session handling.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Removed intent update.

* Feat: added http POST support.

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants