[COM-RPC][Logging] Add logging in case of a possible COM-RPC deadlock#1982
Merged
MFransen69 merged 7 commits intomasterfrom Nov 4, 2025
Merged
[COM-RPC][Logging] Add logging in case of a possible COM-RPC deadlock#1982MFransen69 merged 7 commits intomasterfrom
MFransen69 merged 7 commits intomasterfrom
Conversation
…SLOG in cases of a possible COM-RPC deadlock
VeithMetro
requested review from
Copilot and
sebaszm
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds deadlock detection and improves logging in the COM-RPC communication layer. The changes focus on detecting when an IPC channel already has an outgoing COM-RPC call in progress and logging this condition to prevent potential deadlocks.
- Added deadlock detection check in
IUnknown.hthat logs an error when IPC communication is already in progress - Updated log messages in
Administrator.hfrom SYSLOG to TRACE_L1 for better clarity and consistency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Source/com/IUnknown.h | Added deadlock detection check before invoking IPC calls, logging error when channel is already in progress |
| Source/com/Administrator.h | Replaced SYSLOG with TRACE_L1 and improved message clarity for occupied channel notifications |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sebaszm
previously approved these changes
Oct 31, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sebaszm
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, let's change a SYSLOG to TRACE_1 in case of raising priority to High, to avoid flooding the system