Development/custom codes2#2008
Merged
MFransen69 merged 4 commits intomasterfrom Nov 19, 2025
Merged
Conversation
Contributor
pwielders
approved these changes
Nov 19, 2025
sebaszm
approved these changes
Nov 19, 2025
Contributor
|
Thank you @MFransen69 - Clearing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now full support for uint24_t and in24_t and Custom Code uses this now (of course still inside non complimentary code section :) )
To be able to do this I had to split off the error code from Portability as the U/SInt24 in its separate file still needed ASSERT.
So interface better indicates that only 24bits types are used where and overflow situation (Release, debug will still assert) no longer needs to be checked by a certain magic value externally which is much better but with a method now, added a templated version just like RealSize in case it might be needed more types (e.g. in23_t :) ) in the future in some templated code (also abstracts away the need to call a specific method) (btw did not also make RealSize use the sfinae check to see if the method is there for a reason)
BTW Built for both Linux and Windows, for now only tested on Windows as the Linux lithospere update broke my build and I'll fix that tomorrow (Today that is ;) ). But there is nothing Linux specific on it so it should work anyway.
@mhughesacn I had to move the template code that gave the false warning a few days ago to a new file so you might see the same black duck error again, but it is the same code so again it is just a template specialization for our own types and needs to be done this way so it is a false warning.