Skip to content

Development/custom codes2#2008

Merged
MFransen69 merged 4 commits intomasterfrom
development/CustomCodes2
Nov 19, 2025
Merged

Development/custom codes2#2008
MFransen69 merged 4 commits intomasterfrom
development/CustomCodes2

Conversation

@MFransen69
Copy link
Copy Markdown
Contributor

@MFransen69 MFransen69 commented Nov 18, 2025

Now full support for uint24_t and in24_t and Custom Code uses this now (of course still inside non complimentary code section :) )
To be able to do this I had to split off the error code from Portability as the U/SInt24 in its separate file still needed ASSERT.

So interface better indicates that only 24bits types are used where and overflow situation (Release, debug will still assert) no longer needs to be checked by a certain magic value externally which is much better but with a method now, added a templated version just like RealSize in case it might be needed more types (e.g. in23_t :) ) in the future in some templated code (also abstracts away the need to call a specific method) (btw did not also make RealSize use the sfinae check to see if the method is there for a reason)

BTW Built for both Linux and Windows, for now only tested on Windows as the Linux lithospere update broke my build and I'll fix that tomorrow (Today that is ;) ). But there is nothing Linux specific on it so it should work anyway.

@mhughesacn I had to move the template code that gave the false warning a few days ago to a new file so you might see the same black duck error again, but it is the same code so again it is just a template specialization for our own types and needs to be done this way so it is a false warning.

@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Thunder/2008/rdkcentral/Thunder

  • Commit: 65b4fe4

Report detail: gist'

@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Thunder/2008/rdkcentral/Thunder

  • Commit: fba5795

Report detail: gist'

@mhughesacn
Copy link
Copy Markdown

Thank you @MFransen69 - Clearing this

@MFransen69 MFransen69 merged commit ba71def into master Nov 19, 2025
77 checks passed
@MFransen69 MFransen69 deleted the development/CustomCodes2 branch November 19, 2025 11:44
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants