[IWifiControl] Changing params to Core::OptionalType#417
Merged
pwielders merged 3 commits intordkcentral:masterfrom Apr 7, 2025
Merged
[IWifiControl] Changing params to Core::OptionalType#417pwielders merged 3 commits intordkcentral:masterfrom
pwielders merged 3 commits intordkcentral:masterfrom
Conversation
sebaszm
requested changes
Feb 11, 2025
Contributor
sebaszm
left a comment
sebaszm
left a comment
There was a problem hiding this comment.
Whenever there is a set of an optional field, first check if it's non empty (or not NONE for keys), so they indeed are optional on output as well. Only if they are unset they will be not serialized.
sebaszm
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some options were made optional, if it did not make sense to include them for certain configurations.
Merge with:
rdkcentral/ThunderNanoServices#873