VPLAY-12126:Dynamic restoration of latency target#1278
Merged
Conversation
Vinish100
reviewed
Apr 8, 2026
713513a to
caf017c
Compare
0d2505a to
30f62bf
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds dynamic restoration of LL-DASH latency thresholds after low-buffer episodes by tracking buffer health and stepping min/target/max thresholds back toward config defaults over time.
Changes:
- Extend
AampLatencyMonitorwith danger-buffer tracking + stepwise restoration controls (dangerBufferMs,latencyStableSec) and a notifier API (OnBufferLevelUpdate). - Wire buffer-level notifications from fragment/chunk download success through
MediaStreamContext→StreamAbstractionAAMP→PrivateInstanceAAMP→AampLatencyMonitor. - Update config defaults/keys and expand unit test coverage for shifting, restoration, and episode-guard behavior.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| test/utests/tests/MediaStreamContextTests/FragmentDownloadTests.cpp | Adds a default mock expectation for buffered-duration queries used by new latency-monitor notifications. |
| test/utests/tests/AampLatencyMonitorTests/AampLatencyMonitorTestCases.cpp | Updates/adapts tests to the new low-buffer episode model and adds restoration/episode-guard scenarios. |
| test/utests/fakes/FakeStreamAbstractionAamp.cpp | Adds fake stub for new latency-monitor buffer notification entry point. |
| test/utests/fakes/FakePrivateInstanceAAMP.cpp | Adds fake stub for new PrivateInstanceAAMP buffer notification method. |
| test/utests/fakes/FakeAampLatencyMonitor.cpp | Updates fake latency monitor API to OnBufferLevelUpdate. |
| streamabstraction.cpp | Implements forwarding helper from stream abstraction to PrivateInstanceAAMP for buffer notifications. |
| priv_aamp.h | Declares PrivateInstanceAAMP::NotifyBufferLevelToLatencyMonitor. |
| priv_aamp.cpp | Implements buffer notification forwarding to AampLatencyMonitor and populates new config fields in LL-DASH latency config. |
| StreamAbstractionAAMP.h | Declares StreamAbstractionAAMP::NotifyBufferLevelToLatencyMonitor with Doxygen docs. |
| MediaStreamContext.cpp | Emits buffer-level notifications on successful video fragment/chunk queueing. |
| AampLatencyMonitor.h | Extends LatencyConfig and replaces rebuffer hook with OnBufferLevelUpdate; adds restoration/episode-guard members. |
| AampLatencyMonitor.cpp | Implements low-buffer episode detection, stepwise restoration, and notifier wakeup behavior. |
| AampDefine.h | Adds defaults for latencyStableSec and dangerBufferSec. |
| AampConfig.h | Adds config keys for latencyStableSec and dangerBufferSec. |
| AampConfig.cpp | Registers new float config entries for restoration tuning. |
30f62bf to
650f6f5
Compare
Vinish100
reviewed
Apr 21, 2026
3b6f4d5 to
d43e331
Compare
Reason for change:Add dynamic latency threshold restoration: tighten min/target/max back toward config defaults one step at a time when the buffer consistently maintains above danger buffer of stable sec(300s) after a rebuffering event. Risks: Medium Signed-off-by: varshnie varshniblue14@gmail.com
d43e331 to
85749c6
Compare
Vinish100
reviewed
Apr 24, 2026
DomSyna
pushed a commit
that referenced
this pull request
Apr 29, 2026
Reason for change:Add dynamic latency threshold restoration: tighten min/target/max back toward config defaults one step at a time when the buffer consistently maintains above danger buffer of stable sec(300s) after a rebuffering event. Risks: Medium Test Guidance: refer ticket Signed-off-by: varshnie varshniblue14@gmail.com
Abhi-jith-S
pushed a commit
that referenced
this pull request
May 12, 2026
Reason for change:Add dynamic latency threshold restoration: tighten min/target/max back toward config defaults one step at a time when the buffer consistently maintains above danger buffer of stable sec(300s) after a rebuffering event. Risks: Medium Test Guidance: refer ticket Signed-off-by: varshnie varshniblue14@gmail.com
varatharajan568
pushed a commit
that referenced
this pull request
May 20, 2026
Reason for change:Add dynamic latency threshold restoration: tighten min/target/max back toward config defaults one step at a time when the buffer consistently maintains above danger buffer of stable sec(300s) after a rebuffering event. Risks: Medium Test Guidance: refer ticket Signed-off-by: varshnie varshniblue14@gmail.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change:Add dynamic latency threshold restoration: tighten min/target/max back toward config defaults one step at a time when the buffer consistently maintains above danger buffer of stable sec(300s) after a rebuffering event.
Risks: Medium
Signed-off-by: varshnie varshniblue14@gmail.com