Fix static loop counter in HybridABRManager and mutex unlock-before-r…

[benmesander]

• Bug 1: Replace static int loop with per-instance mRampupFromSteadyStateLoop in HybridABRManager::CheckRampupFromSteadyState, matching the new ABR implementation.
• Bug 2: Move lock.unlock() after all mProfiles reads in updateProfile() for both legacy ABRManager and new abr/abr.cpp to prevent races during period transitions.
• Add unit tests for per-instance loop independence and updateProfile iframe selection.

[Copilot]

Pull request overview

Fixes ABR state/race issues by making the steady-state ramp-up backoff counter instance-scoped in the Hybrid ABR path, and by ensuring updateProfile() keeps the profile mutex held until all mProfiles reads are complete (both legacy and new ABR implementations).

Changes:

• Replace a function-static ramp-up loop counter with a per-instance member (mRampupFromSteadyStateLoop) in HybridABRManager::CheckRampupFromSteadyState.
• Move lock.unlock() to after all mProfiles reads in ABRManager::updateProfile() in both support/aampabr/ABRManager.cpp and abr/abr.cpp.
• Add unit tests for ramp-up loop independence and iframe profile selection behavior in updateProfile().

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/utests/tests/AampAbrTests/AbrTests.cpp	Adds new unit tests for ramp-up loop independence and iframe profile selection in updateProfile().
support/aampabr/HybridABRManager.h	Introduces per-instance mRampupFromSteadyStateLoop state for steady-state ramp-up.
support/aampabr/HybridABRManager.cpp	Uses mRampupFromSteadyStateLoop instead of a function-static counter when computing mMaxBufferCountCheck.
support/aampabr/ABRManager.cpp	Extends mutex hold in updateProfile() until after all mProfiles reads complete.
abr/abr.cpp	Extends mutex hold in updateProfile() until after all mProfiles reads complete (new ABR path).