VPAAMP-129 fix: always compile ResetForTesting, remove AAMP_TEST_BUILD guard#1349
Merged
pstroffolino merged 1 commit intoApr 23, 2026
Merged
Conversation
…D guard The test build does not define AAMP_TEST_BUILD, so the method was compiled out and caused a build error in NetPersonaFitterTestCases.cpp. Remove the ifdef guards — ResetForTesting() is test-only by convention and inert in production (never called outside test code).
Abhi-jith-S
pushed a commit
that referenced
this pull request
May 12, 2026
…D guard (#1349) Reason for Change: The test build does not define AAMP_TEST_BUILD, so the method was compiled out and caused a build error in NetPersonaFitterTestCases.cpp. Remove the ifdef guards — ResetForTesting() is test-only by convention and inert in production (never called outside test code).
varatharajan568
pushed a commit
that referenced
this pull request
May 20, 2026
…D guard (#1349) Reason for Change: The test build does not define AAMP_TEST_BUILD, so the method was compiled out and caused a build error in NetPersonaFitterTestCases.cpp. Remove the ifdef guards — ResetForTesting() is test-only by convention and inert in production (never called outside test code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Surgical follow-up to the VPAAMP-129 merge.
NetPersonaFitter::ResetForTesting()was guarded by#ifdef AAMP_TEST_BUILD, but the unit test build does not define that macro — causing a compile error inNetPersonaFitterTestCases.cpp.Change
Remove the
#ifdef/#endifguards from bothnet_persona_fitter.handnet_persona_fitter.cpp. The method is test-only by convention; its presence in production builds is inert (it is never called outside test code).Files changed
simnet/net_persona_fitter.h— remove#ifdef AAMP_TEST_BUILDguardsimnet/net_persona_fitter.cpp— remove#ifdef AAMP_TEST_BUILDguard