VPAAMP-201 Move SpeedCache to common AampSpeedCache.h header#1360
Merged
Conversation
SpeedCache was defined identically in three places: - priv_aamp.h - abr/abr.cpp - support/aampabr/HybridABRManager.cpp Introduce AampSpeedCache.h as the single canonical definition. Replace each duplicate with an #include "AampSpeedCache.h". Also add the include to abr/abr.h and HybridABRManager.h so their CheckLLDashABRSpeedStoreSize declarations are self-contained and callers no longer need to pull in priv_aamp.h for the struct.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates the duplicated SpeedCache struct into a single shared header (AampSpeedCache.h) so ABR-related code can use it without relying on transitive includes from priv_aamp.h.
Changes:
- Added new shared header
AampSpeedCache.hcontaining the canonicalSpeedCachedefinition. - Replaced three duplicated
SpeedCachedefinitions (inpriv_aamp.h,abr/abr.cpp, andsupport/aampabr/HybridABRManager.cpp) with#include "AampSpeedCache.h". - Made ABR-facing headers self-contained by including
AampSpeedCache.hinabr/abr.handsupport/aampabr/HybridABRManager.h.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| support/aampabr/HybridABRManager.h | Includes shared SpeedCache definition so public declarations are self-contained. |
| support/aampabr/HybridABRManager.cpp | Removes local duplicate SpeedCache and includes shared header. |
| priv_aamp.h | Removes duplicate SpeedCache struct definition and includes shared header. |
| abr/abr.h | Includes shared SpeedCache definition so declarations are self-contained. |
| abr/abr.cpp | Removes local duplicate SpeedCache and includes shared header. |
| AampSpeedCache.h | New canonical shared header defining SpeedCache. |
pstroffolino
added a commit
that referenced
this pull request
Apr 26, 2026
Abhi-jith-S
pushed a commit
that referenced
this pull request
May 12, 2026
* VPAAMP-201 Move SpeedCache to common AampSpeedCache.h header Reason for Change: SpeedCache was defined identically in three places: - priv_aamp.h - abr/abr.cpp - support/aampabr/HybridABRManager.cpp Introduce AampSpeedCache.h as the single canonical definition. Replace each duplicate with an #include "AampSpeedCache.h". Also add the include to abr/abr.h and HybridABRManager.h so their CheckLLDashABRSpeedStoreSize declarations are self-contained and callers no longer need to pull in priv_aamp.h for the struct.
Abhi-jith-S
pushed a commit
that referenced
this pull request
May 12, 2026
varatharajan568
pushed a commit
that referenced
this pull request
May 20, 2026
* VPAAMP-201 Move SpeedCache to common AampSpeedCache.h header Reason for Change: SpeedCache was defined identically in three places: - priv_aamp.h - abr/abr.cpp - support/aampabr/HybridABRManager.cpp Introduce AampSpeedCache.h as the single canonical definition. Replace each duplicate with an #include "AampSpeedCache.h". Also add the include to abr/abr.h and HybridABRManager.h so their CheckLLDashABRSpeedStoreSize declarations are self-contained and callers no longer need to pull in priv_aamp.h for the struct.
varatharajan568
pushed a commit
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change: SpeedCache was defined identically in three places:
Introduce AampSpeedCache.h as the single canonical definition. Replace each duplicate with an #include "AampSpeedCache.h". Also add the include to abr/abr.h and HybridABRManager.h so their CheckLLDashABRSpeedStoreSize declarations are self-contained and callers no longer need to pull in priv_aamp.h for the struct.