Skip to content

VPAAMP-157: Bring dev_sprint_25_2 to parity with support/2.11.1_8.4_vipa#1374

Merged
pstroffolino merged 1 commit into
dev_sprint_25_2from
feature/VPAAMP-157-parity
Apr 28, 2026
Merged

VPAAMP-157: Bring dev_sprint_25_2 to parity with support/2.11.1_8.4_vipa#1374
pstroffolino merged 1 commit into
dev_sprint_25_2from
feature/VPAAMP-157-parity

Conversation

@pstroffolino
Copy link
Copy Markdown
Contributor

Reason for Change: Apply the same trickplay-seek rate fix to SeekAfterPrepared() that was already applied to SeekInternal() in PR #1351. When the deferred seek path is taken (eSTATE_INITIALIZED / eSTATE_PREPARING), positional seeks now preserve the trickplay rate and skip the spurious speed=1 notification, consistent with the SeekInternal() behaviour.

  • Add three unit tests covering the trickplay seek scenarios:
    • SeekInternal_TrickplayPositionSeek_PreservesRateNoSpeedEvent
    • SeekInternal_TrickplaySeekToLive_ResetsRateAndNotifies
    • SeekInternal_TrickplaySeekToEnd_ResetsRateAndNotifies

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns dev_sprint_25_2 with support/2.11.1_8.4_vipa for VPAAMP-157 by fixing deferred-seek trickplay behavior so positional seeks preserve the current trickplay rate and avoid emitting a spurious normal-speed event.

Changes:

  • Update SeekAfterPrepared() to only reset rate (and trigger a speed-changed notification) for seek-to-live / seek-to-end while in trickplay; preserve rate for positional seeks.
  • Add unit tests covering SeekInternal() trickplay seek scenarios (positional seek preserves rate; seek-to-live and seek-to-end reset rate and notify).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
main_aamp.cpp Adjusts deferred seek (SeekAfterPrepared) to match SeekInternal trickplay seek rate/notification behavior.
test/utests/tests/PlayerInstanceAAMP/PlayerInstanceAAMPTestsMain.cpp Adds three unit tests validating SeekInternal trickplay seek rate and notification behavior.

Comment thread main_aamp.cpp Outdated
Comment thread main_aamp.cpp Outdated
@pstroffolino pstroffolino force-pushed the feature/VPAAMP-157-parity branch from 508a465 to 0f188de Compare April 28, 2026 17:07
- Apply the same trickplay-seek rate fix to SeekAfterPrepared() that was
  already applied to SeekInternal() in PR #1351. When the deferred seek
  path is taken (eSTATE_INITIALIZED / eSTATE_PREPARING), positional seeks
  now preserve the trickplay rate and skip the spurious speed=1
  notification, consistent with the SeekInternal() behaviour.

- Add three unit tests covering the trickplay seek scenarios:
    * SeekInternal_TrickplayPositionSeek_PreservesRateNoSpeedEvent
    * SeekInternal_TrickplaySeekToLive_ResetsRateAndNotifies
    * SeekInternal_TrickplaySeekToEnd_ResetsRateAndNotifies
@pstroffolino pstroffolino force-pushed the feature/VPAAMP-157-parity branch from 0f188de to 805bc4b Compare April 28, 2026 17:21
@pstroffolino pstroffolino merged commit 428a90f into dev_sprint_25_2 Apr 28, 2026
9 checks passed
@pstroffolino pstroffolino deleted the feature/VPAAMP-157-parity branch April 28, 2026 17:33
DomSyna pushed a commit that referenced this pull request Apr 29, 2026
…ipa (#1374)

Reason for Change: Apply the same trickplay-seek rate fix to SeekAfterPrepared() that was
  already applied to SeekInternal() in PR #1351. When the deferred seek
  path is taken (eSTATE_INITIALIZED / eSTATE_PREPARING), positional seeks
  now preserve the trickplay rate and skip the spurious speed=1
  notification, consistent with the SeekInternal() behaviour.

- Add three unit tests covering the trickplay seek scenarios:
    * SeekInternal_TrickplayPositionSeek_PreservesRateNoSpeedEvent
    * SeekInternal_TrickplaySeekToLive_ResetsRateAndNotifies
    * SeekInternal_TrickplaySeekToEnd_ResetsRateAndNotifies
pstroffolino pushed a commit that referenced this pull request May 7, 2026
* Revert "VPAAMP-157: Bring dev_sprint_25_2 to parity with support/2.11.1_8.4_vipa (#1374)"

This reverts commit 428a90f.

* Revert "VPAAMP-157 "[VIPA][Linear][VOD] [Rewind]Spurious PlaybackSpeedChanged event with speed=1 emitted during rewind speed change (e.g., -12x to -30x" (#1351)"

This reverts commit 97de921.

---------

Co-authored-by: Neil Butler <nebutler@cf-regulus-01.synamedialabs.com>
Abhi-jith-S pushed a commit that referenced this pull request May 12, 2026
…ipa (#1374)

Reason for Change: Apply the same trickplay-seek rate fix to SeekAfterPrepared() that was
  already applied to SeekInternal() in PR #1351. When the deferred seek
  path is taken (eSTATE_INITIALIZED / eSTATE_PREPARING), positional seeks
  now preserve the trickplay rate and skip the spurious speed=1
  notification, consistent with the SeekInternal() behaviour.

- Add three unit tests covering the trickplay seek scenarios:
    * SeekInternal_TrickplayPositionSeek_PreservesRateNoSpeedEvent
    * SeekInternal_TrickplaySeekToLive_ResetsRateAndNotifies
    * SeekInternal_TrickplaySeekToEnd_ResetsRateAndNotifies
varshnie pushed a commit that referenced this pull request May 18, 2026
* Revert "VPAAMP-157: Bring dev_sprint_25_2 to parity with support/2.11.1_8.4_vipa (#1374)"

This reverts commit 428a90f.

* Revert "VPAAMP-157 "[VIPA][Linear][VOD] [Rewind]Spurious PlaybackSpeedChanged event with speed=1 emitted during rewind speed change (e.g., -12x to -30x" (#1351)"

This reverts commit 97de921.

---------

Co-authored-by: Neil Butler <nebutler@cf-regulus-01.synamedialabs.com>
varatharajan568 pushed a commit that referenced this pull request May 20, 2026
…ipa (#1374)

Reason for Change: Apply the same trickplay-seek rate fix to SeekAfterPrepared() that was
  already applied to SeekInternal() in PR #1351. When the deferred seek
  path is taken (eSTATE_INITIALIZED / eSTATE_PREPARING), positional seeks
  now preserve the trickplay rate and skip the spurious speed=1
  notification, consistent with the SeekInternal() behaviour.

- Add three unit tests covering the trickplay seek scenarios:
    * SeekInternal_TrickplayPositionSeek_PreservesRateNoSpeedEvent
    * SeekInternal_TrickplaySeekToLive_ResetsRateAndNotifies
    * SeekInternal_TrickplaySeekToEnd_ResetsRateAndNotifies
varatharajan568 pushed a commit that referenced this pull request May 20, 2026
* Revert "VPAAMP-157: Bring dev_sprint_25_2 to parity with support/2.11.1_8.4_vipa (#1374)"

This reverts commit 428a90f.

* Revert "VPAAMP-157 "[VIPA][Linear][VOD] [Rewind]Spurious PlaybackSpeedChanged event with speed=1 emitted during rewind speed change (e.g., -12x to -30x" (#1351)"

This reverts commit 97de921.

---------

Co-authored-by: Neil Butler <nebutler@cf-regulus-01.synamedialabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants