Skip to content

VPAAMP-365: change default preferredDrm to wide vine#1473

Merged
pstroffolino merged 2 commits into
dev_sprint_25_2from
feature/VPAAMP_365
May 21, 2026
Merged

VPAAMP-365: change default preferredDrm to wide vine#1473
pstroffolino merged 2 commits into
dev_sprint_25_2from
feature/VPAAMP_365

Conversation

@Reshma-JO07
Copy link
Copy Markdown
Contributor

Reason for change: Set default drm as widevine
as part of VPAAMP-31
Test Procedure: updated in ticket
Risks: Medium

@Reshma-JO07 Reshma-JO07 requested a review from a team as a code owner May 19, 2026 17:27
@Reshma-JO07 Reshma-JO07 force-pushed the feature/VPAAMP_365 branch from f301fff to 2d3cf76 Compare May 19, 2026 17:42
Copy link
Copy Markdown
Contributor

@Vinish100 Vinish100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Reason for change: Set default drm as widevine
as part of VPAAMP-31
Test Procedure: updated in ticket
Risks: Medium

Signed-off-by: Reshma-JO07 <sreshmaraphaelk@gmail.com>
@Vinish100 Vinish100 force-pushed the feature/VPAAMP_365 branch from 2d3cf76 to bfe0a73 Compare May 20, 2026 06:15
@pstroffolino pstroffolino requested a review from Copilot May 21, 2026 20:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the default DRM selection for preferredDrm in configuration defaults.

Changes:

  • Switches the preferredDrm default from PlayReady to WideVine in the integer config lookup table.

Comment thread AampConfig.cpp
{DEFAULT_BUFFER_HEALTH_MONITOR_DELAY,"bufferHealthMonitorDelay",eAAMPConfig_BufferHealthMonitorDelay,false},
{DEFAULT_BUFFER_HEALTH_MONITOR_INTERVAL,"bufferHealthMonitorInterval",eAAMPConfig_BufferHealthMonitorInterval,false},
{eDRM_PlayReady,"preferredDrm",eAAMPConfig_PreferredDRM,true,eCONFIG_RANGE_DRM_SYSTEMS},
{eDRM_WideVine,"preferredDrm",eAAMPConfig_PreferredDRM,true,eCONFIG_RANGE_DRM_SYSTEMS},
@pstroffolino pstroffolino changed the title VPAAMP-365: Make default preferredDrm as playready VPAAMP-365: change default preferredDrm to wide vine May 21, 2026
@pstroffolino pstroffolino merged commit 36ac8dc into dev_sprint_25_2 May 21, 2026
9 of 10 checks passed
@pstroffolino pstroffolino deleted the feature/VPAAMP_365 branch May 21, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants