VPAAMP-387 missing null pointer guards for mMediaStreamContext[eMEDIATYPE_VIDEO] and mMediaStreamContext[eMEDIATYPE_AUDIO]

[pstroffolino]

Reason for Change: static code analysis noted some missing null pointer guards - appears to be longstanding issue

Test Guidance: will add new test to force the path that otherwise would have caused crash

Risk: Low

[Copilot]

Pull request overview

This PR targets VPAAMP-387 by adding null-pointer guards in StreamAbstractionAAMP_MPD::StreamSelection() to prevent potential crashes when accessing mMediaStreamContext[eMEDIATYPE_VIDEO] / mMediaStreamContext[eMEDIATYPE_AUDIO].

Changes:

• Added a null check for video/audio mMediaStreamContext entries before the “audio-only period” handling block.
• Added an error log when a null track context is detected.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (2)

test/utests/tests/StreamAbstractionAAMP_MPD/StreamSelectionTest.cpp:825

• EXPECT_NO_FATAL_FAILURE does not protect against process crashes/segfaults, so it doesn’t actually validate the stated “DoesNotCrash” intent (a null dereference would still abort the whole test binary). Consider calling InvokeStreamSelection() directly (a crash will fail the test run) and/or adjust the assertion/comment to reflect what is actually being checked (no gtest fatal failures).

	// StreamSelection() must complete without dereferencing the null audio
	// context.  Both guard sites (audio-only copy block and SetCurrentBandWidth
	// loop) are reached in this path.
	EXPECT_NO_FATAL_FAILURE(mStreamAbstractionAAMP_MPD->InvokeStreamSelection());

fragmentcollector_mpd.cpp:7326

• AAMPLOG_ERR("... null track context in audio-only check") doesn’t indicate which context is null (audio vs video) or include useful state (e.g., play rate / mMaxTracks / mNumberOfTracks), which makes triage harder. Consider expanding the message to include which pointer(s) are null and relevant track/rate context.

		if (mPlayRate == AAMP_NORMAL_PLAY_RATE)
		{
			AAMPLOG_ERR("StreamAbstractionAAMP_MPD: null track context in audio-only check");
		}