VPAAMP-102: Fix duplicate res metric key in drmMetadata networkMetrics and documentation#1491
Merged
Merged
Conversation
b768d65 to
03933a6
Compare
Reshma-JO07
reviewed
May 21, 2026
Reshma-JO07
reviewed
May 21, 2026
Reshma-JO07
reviewed
May 21, 2026
bbce1de to
c5bb1d4
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a duplicate networkMetrics JSON key in DRM metadata telemetry by renaming the curl “resolve” metric key from res (conflicting with HTTP response) to dns, and updates unit-test validation and public UVE documentation accordingly.
Changes:
- Fix
UpdateLicenseMetrics()to emitdns(DNS resolve time) instead of a duplicatereskey. - Add/extend test plumbing to capture
networkMetricsJSON fromDrmMetaDataEventand validate all expected keys/values. - Update
AAMP-UVE-API.mdto document the correctednetworkMetricsschema and examples.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
drm/AampDRMLicManager.cpp |
Fixes the duplicated JSON key by emitting dns for resolve timing and clarifies key meanings. |
test/utests/fakes/FakeAampEvent.cpp |
Allows tests to intercept setNetworkMetricData() via the global mock delegate. |
test/utests/mocks/MockDrmMetaDataEvent.h |
Adds setNetworkMetricData() to the mock so tests can capture the JSON payload. |
test/utests/tests/AampDRMLicManagerTests/AampDRMLicManagerTestCases.cpp |
Adds a new test asserting the complete networkMetrics keyset and values. |
AAMP-UVE-API.md |
Updates API documentation to reflect the corrected networkMetrics schema and removes the key collision. |
…s and documentation Reason for change: Modified res override with dns Test Procedure: Refer jira ticket VPAAMP-102 Priority: P1 Signed-off-by: srikanthreddybijjam-comcast <srikanthreddybijjam.2000@gmail.com>
c5bb1d4 to
3e41304
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Modified res override with dns and updated Documentation.
Test Procedure: Refer Jira ticket VPAAMP-102
Priority: P1