VPAAMP-371 Replatce SyncBegin and Sync end with modern cpp RAII imple…

[DomSyna]

SyncBegin()/SyncEnd() were thin wrappers around mLock.lock()/mLock.unlock()] that required callers to manually match every acquire with a release.

[Copilot]

Pull request overview

This PR modernizes PrivateInstanceAAMP’s “GStreamer operation” locking by replacing the manual SyncBegin()/SyncEnd() pair with an RAII-style SyncLock() that returns a std::unique_lock<std::recursive_mutex>, reducing the risk of mismatched lock/unlock calls across the player and collectors.

Changes:

• Replace SyncBegin()/SyncEnd() with [[nodiscard]] SyncLock() in PrivateInstanceAAMP (header + implementation).
• Update call sites across player/collectors/DRM and unit-test fakes/mocks to use scoped RAII locking.
• Adjust unit tests to validate the new API entry point (SyncLock()).

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
priv_aamp.h	Removes SyncBegin/SyncEnd declarations and introduces [[nodiscard]] SyncLock() with updated Doxygen.
priv_aamp.cpp	Implements SyncLock() and updates multiple internal critical sections to use RAII locking.
aampgstplayer.cpp	Updates AAMPGstPlayer::Pause() to use SyncLock() instead of manual begin/end.
fragmentcollector_mpd.cpp	Updates MPD collector destructor cleanup to use scoped SyncLock().
fragmentcollector_hls.cpp	Updates HLS collector destructor cleanup to use scoped SyncLock().
drm/DrmInterface.cpp	Updates curl termination path to use scoped SyncLock().
test/utests/fakes/FakePrivateInstanceAAMP.cpp	Removes fake SyncBegin/SyncEnd stubs and adds fake SyncLock() implementation.
test/utests/drm/mocks/aampMocks.cpp	Removes mock SyncBegin/SyncEnd stubs and adds mock SyncLock() implementation.
test/utests/tests/PrivAampTests/PrivAampTests.cpp	Updates unit test to call SyncLock() instead of SyncBegin/SyncEnd.

[dnfaulkner]

Very nice :)

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.