VPAAMP-392 osx build failure (l1test)#1506
Merged
Merged
Conversation
Reason for Change: apply identical framework-vs-homebrew detection logic to run.sh so it behaves consistently with install_aampcli.sh Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an OS X L1 test build failure by making test/utests/run.sh detect GStreamer the same way as scripts/install_aampcli.sh: prefer the official macOS GStreamer framework if present, otherwise fall back to Homebrew (and fail early with a clear install message if neither is available).
Changes:
- Add GStreamer framework-vs-Homebrew detection on macOS for
PKG_CONFIG_PATHsetup intest/utests/run.sh. - Include
gst-plugins-basepkg-config path when using Homebrew to ensuregstreamer-app-1.0can be resolved. - Improve failure behavior by emitting an explicit “GStreamer not found” error instead of letting CMake fail opaquely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change: apply identical framework-vs-homebrew detection logic to utests/run.sh so it behaves consistently with install_aampcli.sh