Skip to content

VPAAMP-413 Speed up L1 tests#1509

Merged
pstroffolino merged 4 commits into
dev_sprint_25_2from
feature/VPAAMP-413
May 28, 2026
Merged

VPAAMP-413 Speed up L1 tests#1509
pstroffolino merged 4 commits into
dev_sprint_25_2from
feature/VPAAMP-413

Conversation

@jfagunde
Copy link
Copy Markdown
Contributor

Reason for Change: Speed up L1 tests

Summary of Changes:

  • Modify run.sh to print list of slow tests that take longer than 1s
  • Make AampCurlDownloader delay between 502 retries configurable
  • Modify various L1 tests to make them quicker

Test Procedure: L1 tests should pass and slow tests printed

Priority: P2

Risks: Low

@jfagunde jfagunde requested a review from Copilot May 27, 2026 11:03
@jfagunde jfagunde marked this pull request as ready for review May 27, 2026 11:07
@jfagunde jfagunde requested a review from a team as a code owner May 27, 2026 11:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Speeds up the AAMP L1 unit-test workflow by shortening several long waits/timeouts, adding reporting for slow-running tests, and making the 502-retry backoff configurable in the curl downloader.

Changes:

  • Add ctest JUnit output + a helper script to print tests exceeding a 1s duration threshold.
  • Add iDownload502RetryWaitMs to curl download config and use it for 502 retry delays (tests can set it to 0 to run faster).
  • Reduce waits/timeouts in a few L1 tests to shorten suite runtime.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/utests/tests/PrivAampTests/PrivAampTests.cpp Reduced a fixed sleep in a detach/async-event test.
test/utests/tests/MediaTrackTests/MediaTrackTests.cpp Reduced a wait timeout in a condition-variable timing test.
test/utests/tests/AampMPDDownloader/FunctionalTests.cpp Shortened live-refresh polling windows; adjusted MPD sample to refresh faster.
test/utests/tests/AampLatencyMonitorTests/AampLatencyMonitorTestCases.cpp Reduced “stable” window/timeouts to speed up restoration-cycle testing.
test/utests/tests/AampCurlDownloader/FunctionalTests.cpp Sets new 502 retry wait to 0 to remove delay in test.
test/utests/run.sh Adds JUnit output and invokes slow-test listing script after ctest.
test/utests/list_slow_tests.py New script to parse CTest JUnit XML and list slow tests.
downloader/AampCurlDownloader.h Adds 502 retry wait config field; adds AampDefine.h include.
downloader/AampCurlDownloader.cpp Uses configurable 502 retry wait instead of fixed constant.

Comment thread test/utests/run.sh
Comment thread test/utests/tests/PrivAampTests/PrivAampTests.cpp
Comment thread test/utests/tests/MediaTrackTests/MediaTrackTests.cpp Outdated
Comment thread downloader/AampCurlDownloader.h Outdated
jfagunde added 4 commits May 28, 2026 08:20
Reason for Change: Speed up L1 tests

Summary of Changes:
- Modify run.sh to print list of slow tests that take longer than 1s
- Make AampCurlDownloader delay between 502 retries configurable
- Modify various L1 tests to make them quicker

Test Procedure: L1 tests should pass and slow tests printed

Priority: P2

Risks: Low
@pstroffolino pstroffolino merged commit dbe5990 into dev_sprint_25_2 May 28, 2026
11 checks passed
@pstroffolino pstroffolino deleted the feature/VPAAMP-413 branch May 28, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants