VPAAMP-413 Speed up L1 tests#1509
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Speeds up the AAMP L1 unit-test workflow by shortening several long waits/timeouts, adding reporting for slow-running tests, and making the 502-retry backoff configurable in the curl downloader.
Changes:
- Add
ctestJUnit output + a helper script to print tests exceeding a 1s duration threshold. - Add
iDownload502RetryWaitMsto curl download config and use it for 502 retry delays (tests can set it to 0 to run faster). - Reduce waits/timeouts in a few L1 tests to shorten suite runtime.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/utests/tests/PrivAampTests/PrivAampTests.cpp | Reduced a fixed sleep in a detach/async-event test. |
| test/utests/tests/MediaTrackTests/MediaTrackTests.cpp | Reduced a wait timeout in a condition-variable timing test. |
| test/utests/tests/AampMPDDownloader/FunctionalTests.cpp | Shortened live-refresh polling windows; adjusted MPD sample to refresh faster. |
| test/utests/tests/AampLatencyMonitorTests/AampLatencyMonitorTestCases.cpp | Reduced “stable” window/timeouts to speed up restoration-cycle testing. |
| test/utests/tests/AampCurlDownloader/FunctionalTests.cpp | Sets new 502 retry wait to 0 to remove delay in test. |
| test/utests/run.sh | Adds JUnit output and invokes slow-test listing script after ctest. |
| test/utests/list_slow_tests.py | New script to parse CTest JUnit XML and list slow tests. |
| downloader/AampCurlDownloader.h | Adds 502 retry wait config field; adds AampDefine.h include. |
| downloader/AampCurlDownloader.cpp | Uses configurable 502 retry wait instead of fixed constant. |
Reason for Change: Speed up L1 tests Summary of Changes: - Modify run.sh to print list of slow tests that take longer than 1s - Make AampCurlDownloader delay between 502 retries configurable - Modify various L1 tests to make them quicker Test Procedure: L1 tests should pass and slow tests printed Priority: P2 Risks: Low
de0ab47 to
c77be00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change: Speed up L1 tests
Summary of Changes:
Test Procedure: L1 tests should pass and slow tests printed
Priority: P2
Risks: Low