VPLAY-11848: Cloud TSB No subtitles after rewinding (L3 Test 2014), regression from LLDASH optimizations#702
Merged
pstroffolino merged 1 commit intodev_sprint_25_2from Nov 28, 2025
Conversation
nu641001
force-pushed
the
feature/VPLAY-11848
branch
from
b2e49cd to
535872f
Compare
jfagunde
reviewed
Nov 27, 2025
nu641001
force-pushed
the
feature/VPLAY-11848
branch
from
535872f to
159e374
Compare
…egression from LLDASH optimizations Reason for change: Correcting the position in FetchFragment and before UpdateTSAfterFetch Risks: Low Test Procedure: Test with 2014 test case Priority: P1
nu641001
force-pushed
the
feature/VPLAY-11848
branch
from
159e374 to
4b1f8a7
Compare
pstroffolino
approved these changes
Nov 28, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a subtitle regression issue (VPLAY-11848) that occurred after LLDASH optimizations by correcting how PTS (Presentation Time Stamp) values are calculated and applied.
Key Changes:
- Simplified PTS calculation by replacing AampTicks/AampTime wrapper classes with direct division for better performance
- Fixed PTS offset application by moving it from an unused code path to where fragment position is actually set
- Added comprehensive parameterized tests covering all combinations of chunk mode and PTS restamp configurations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| fragmentcollector_mpd.cpp | Simplified PTS calculation using direct division instead of AampTime wrapper classes |
| MediaStreamContext.cpp | Fixed PTS offset bug by moving offset application from CacheFragment to OnFragmentDownloadSuccess where position is actually set |
| test/utests/tests/MediaStreamContextTests/FragmentDownloadTests.cpp | Added parameterized tests covering chunk mode and PTS restamp scenarios, replacing two separate test cases with one comprehensive test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nejuma1
pushed a commit
that referenced
this pull request
Jan 30, 2026
…cast_comrpc_support RDKEMW-1017 RDKEMW-1018: Miracast COMRPC Support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Correcting the position in FetchFragment and before UpdateTSAfterFetch
Risks: Low
Test Procedure: Test with 2014 test case
Priority: P1