RDKB-64184, RDKB-63906 : Remove platform specific checks for network intelligence feature#83
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the model/platform-specific gating for the Network Intelligence (NI) feature and relies on the NI RFC flag to control whether NI is enabled/disabled during advanced security startup.
Changes:
- Removed
NI_SUPPORTEDplatform detection/export logic fromscripts/advsec.sh. - Updated NI enable/disable logic in
scripts/start_adv_security.shto be driven directly byADVSEC_NETWORKINTELLIGENCE_RFC_ENABLED.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/start_adv_security.sh | Adjusts NI startup gating to use the NI RFC value directly (removes prior platform-based guard). |
| scripts/advsec.sh | Removes XB8-specific NI_SUPPORTED environment setup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SanthoshGujulvajagadeesh
changed the title
GoutamD2905
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Removed platform specific checks for network intelligence feature
Test Procedure:
Risks: Low
Priority: P1
Signed-off-by: Santhosh_GujulvaJagadeesh@comcast.com