RDKB-64184, RDKB-63906 : start or stop Network Intelligence (NI) service only if present#84
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Advanced Security startup script to manage the Network Intelligence (NI) systemd service more safely, avoiding start/stop attempts when the NI service is not installed/present on the device.
Changes:
- Treat NI RFC enablement as a simple
if enabled -> enable else -> disableflow (consistent with other RFC toggles in the script). - Gate
systemctl start/stopfor NI behind a unit-file presence check to avoid failures when the NI service is absent.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
GoutamD2905
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: On NI RFC DML parameter enable or disable, start or stop NI service only if present.
Test Procedure:
Risks: Low
Priority: P1
Signed-off-by: Santhosh_GujulvaJagadeesh@comcast.com