RDKE-979 : standardize the TARGET_VENDOR variable with -rdk#17
Merged
sreejithravi086 merged 2 commits intoDec 1, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes the TARGET_VENDOR variable to "-rdk" across the build system to ensure compatibility with toolchain prebuilt libraries like libgcc. Without a common TARGET_VENDOR value, the folder structure for toolchain components would be inconsistent, preventing proper use of prebuilt libraries across all stack layers.
Key Changes:
- Adds conditional logic to set
TARGET_VENDORto "-rdk" if not already defined - Writes the standardized
TARGET_VENDORvalue toconf/local.confwith explanatory comments
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maniselva006c
approved these changes
Dec 1, 2025
sreejithravi086
deleted the
feature/RDKE-979-Setting-default-TARGET_VENDOR-as-rdk
branch
maniselva006c
left a comment
maniselva006c
left a comment
There was a problem hiding this comment.
This change can be reverted once the changes are moved to oss-ref layer.
Make sure this change doesn't cause any build error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize the TARGET_VENDOR variable
The TARGET_VENDOR variable is used to generate the folder structure for toolchain components.
STAGING_BINDIR_TOOLCHAIN = "${STAGING_DIR_NATIVE}${bindir_native}/${TARGET_ARCH}${TARGET_VENDOR}-${TARGET_OS}".
To ensure that the prebuilt libraries are usable across all stack layers, we should standardize the TARGET_VENDOR value across the entire system.
If we do not use a common value for this variable, we won't be able to use the toolchain's prebuilt libraries, such as libgcc.