RDKB-64593 : Coverity issues in ccsp-common-library phase 2#110
Merged
Conversation
Reason for change: To address high impact coverity issues Test Procedure: There should not be any coverity issues mentioned in the ticket Risks: None Signed-off-by: kavyachowdahalli_suresh@comcast.com
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses high-impact Coverity findings in ccsp-common-library by tightening control-flow to avoid unsafe operations and ensure allocated resources are released on error paths.
Changes:
- Prevent potential out-of-bounds/overflow behavior in
BspTemplateArchiveSaveToFile()by stopping the write loop whensprintf_sfails. - Fix resource leaks in
SetParamValueHelper()by routing error returns through a cleanup label that frees allocated strings. - Fix resource leaks in
SlapDslhParamtoIsParameterReadOnly()by ensuring allocated strings are freed before returning the read-only result.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
source/cosa/utilities/bsp_eng/bspeng_archive_co_process.c |
Stops comma-separated serialization loop on sprintf_s failure to avoid unsafe subsequent operations. |
source/cosa/package/slap/services/dslh/SlapDslhParamTree/slap_dslh_paramto_access.c |
Uses goto cleanup on error/return paths to consistently release allocated resources and resolve Coverity leak reports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
snayak002c
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: To address high impact coverity issues
Test Procedure: There should not be any coverity issues mentioned in the ticket
Risks: None
Signed-off-by: kavyachowdahalli_suresh@comcast.com