RDKCOM-5493: RDKBDEV-3340 Fix sometimes TR069 crash when do tr069 fw upgrade longrun#69
Merged
snayak002c merged 2 commits intordkcentral:developfrom Feb 2, 2026
Merged
Conversation
Reason for change: Sometimes CcspTr069PaSsp will crash when do tr069 firmware upgrade longrun, find that it was caused by CcspNsMgrDiscoverNamespace function, sometimes it will access an illegal pointer. Test Procedure: 1. Let CcspTR069PaSsp connect to acs server. 2. Do TR069 Firmware Upgrade test (may need longrun to reproduce) Risks: Low Signed-off-by: Owen Lu <owen_lu@sercomm.com>
snayak002c
approved these changes
Feb 2, 2026
| if( pNewSpace == NULL) | ||
| if( pNewSpace == NULL || pAtomNamespace == NULL ) | ||
| { | ||
| return CCSP_CR_ERR_INVALID_PARAM; |
Contributor
There was a problem hiding this comment.
Coverity Issue - Resource leak
Variable "pNewSpace" going out of scope leaks the storage it points to.
High Impact, CWE-404
RESOURCE_LEAK
bunnam988
pushed a commit
that referenced
this pull request
Feb 20, 2026
…upgrade longrun (#69) Reason for change: Sometimes CcspTr069PaSsp will crash when do tr069 firmware upgrade longrun, find that it was caused by CcspNsMgrDiscoverNamespace function, sometimes it will access an illegal pointer. Test Procedure: 1. Let CcspTR069PaSsp connect to acs server. 2. Do TR069 Firmware Upgrade test (may need longrun to reproduce) Risks: Low Signed-off-by: Owen Lu <owen_lu@sercomm.com> Signed-off-by: Owen Lu <owen_lu@sercomm.com> Co-authored-by: Santosh Nayak <70348540+snayak002c@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change:
Sometimes CcspTr069PaSsp will crash when do tr069 firmware upgrade longrun, find that it was caused by CcspNsMgrDiscoverNamespace function, sometimes it will access an illegal pointer.
Test Procedure:
Risks: Low
Signed-off-by: Owen Lu owen_lu@sercomm.com