Skip to content

RDKEMW-8815: only return SUCCESS for autolookup if it found at least 1 code #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

RDKEMW-8815: only return SUCCESS for autolookup if it found at least 1 code #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/irdb/ctrlm_irdb_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,18 +397,18 @@ bool ctrlm_irdb_interface_t::get_ir_codes_by_autolookup(ctrlm_autolookup_ranked_
if(ir_codes.size() > 0) {
if(type != CTRLM_IRDB_DEV_TYPE_INVALID) {
codes[type].insert(codes[type].end(), ir_codes.begin(), ir_codes.end());
ret = true;
} else {
XLOGD_ERROR("edid dev type invalid");
}
} else {
XLOGD_WARN("no codes for edid data");
XLOGD_ERROR("no codes for edid data");
}
ret = true;
} else {
XLOGD_ERROR("Failed getting codes by edid");
}
} else {
XLOGD_INFO("No EDID data");
XLOGD_ERROR("No EDID data");
}
} else {
XLOGD_ERROR("display_settings is NULL");
Expand All @@ -426,19 +426,19 @@ bool ctrlm_irdb_interface_t::get_ir_codes_by_autolookup(ctrlm_autolookup_ranked_
if(ir_codes.size() > 0) {
if(type != CTRLM_IRDB_DEV_TYPE_INVALID) {
codes[type].insert(codes[type].end(), ir_codes.begin(), ir_codes.end());
ret = true;
} else {
XLOGD_ERROR("cec dev type invalid");
}
} else {
XLOGD_WARN("no code for cec device <%s>", itr.osd.c_str());
}
ret = true;
} else {
XLOGD_WARN("Failed to get codes for cec device <%s>", itr.osd.c_str());
}
}
} else {
XLOGD_INFO("No CEC device data");
XLOGD_ERROR("No CEC device data");
}
} else {
XLOGD_ERROR("cec is NULL");
Expand All @@ -456,18 +456,18 @@ bool ctrlm_irdb_interface_t::get_ir_codes_by_autolookup(ctrlm_autolookup_ranked_
if(ir_codes.size() > 0) {
if(type != CTRLM_IRDB_DEV_TYPE_INVALID) {
codes[type].insert(codes[type].end(), ir_codes.begin(), ir_codes.end());
ret = true;
} else {
XLOGD_WARN("port %d infoframe dev type invalid", itr.first);
XLOGD_ERROR("port %d infoframe dev type invalid", itr.first);
}
} else {
XLOGD_WARN("no code for port %d infoframe", itr.first);
}
ret = true;
} else {
XLOGD_WARN("Failed to get codes for port %d infoframe", itr.first);
}
} else {
XLOGD_INFO("no infoframe for port %d", itr.first);
XLOGD_WARN("no infoframe for port %d", itr.first);
}
}
} else {
Expand All @@ -485,19 +485,19 @@ bool ctrlm_irdb_interface_t::get_ir_codes_by_autolookup(ctrlm_autolookup_ranked_
if(ir_codes.size() > 0) {
if(type != CTRLM_IRDB_DEV_TYPE_INVALID) {
codes[type].insert(codes[type].end(), ir_codes.begin(), ir_codes.end());
ret = true;
} else {
XLOGD_WARN("cec dev type invalid");
XLOGD_ERROR("cec dev type invalid");
}
} else {
XLOGD_WARN("no code for cec device <%s>", itr.osd.c_str());
}
ret = true;
} else {
XLOGD_WARN("Failed to get codes for cec device <%s>", itr.osd.c_str());
}
}
} else {
XLOGD_INFO("No CEC device data");
XLOGD_ERROR("No CEC device data");
}
} else {
XLOGD_ERROR("cec_sink is NULL");
Expand Down