Skip to content

Conversation

@dwolaver
Copy link
Contributor

No description provided.

@dwolaver dwolaver requested a review from a team as a code owner October 10, 2025 18:12
Copy link
Contributor

@egalla204 egalla204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for test

egalla204
egalla204 previously approved these changes Nov 17, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the VSDK_CURTAIL build flags from the xr-voice-sdk by updating function signatures to their non-curtailed versions. The changes expose previously conditionally-compiled parameters.

Key Changes:

  • Updated xlog_init to accept a 5th parameter (boolean flag)
  • Updated vsdk_init to accept 2 additional parameters for file logging configuration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/factory/ctrlmf_version.c Added 5th boolean parameter (false) to xlog_init call
src/ctrlm_main.cpp Added 2 additional parameters to vsdk_init call for filename and file size configuration, initialized to NULL and 0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +483 to +485
const char *filename = NULL;
uint32_t file_size_max = 0;
vsdk_init(true, filename, file_size_max);
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intermediate variables filename and file_size_max are unnecessary. They are initialized with constant values and immediately passed to vsdk_init without any modification. Consider simplifying by passing the values directly:

vsdk_init(true, NULL, 0);

This would eliminate the need for lines 484-485 and make the code more concise.

Suggested change
const char *filename = NULL;
uint32_t file_size_max = 0;
vsdk_init(true, filename, file_size_max);
vsdk_init(true, NULL, 0);

Copilot uses AI. Check for mistakes.
@dwolaver dwolaver merged commit bcc3be8 into develop Nov 19, 2025
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants