-
Notifications
You must be signed in to change notification settings - Fork 3
RDKEMW-9124 : remove xr-voice-sdk build flags - VSDK_CURTAIL #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDKEMW-9124 : remove xr-voice-sdk build flags - VSDK_CURTAIL #132
Conversation
egalla204
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved for test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the VSDK_CURTAIL build flags from the xr-voice-sdk by updating function signatures to their non-curtailed versions. The changes expose previously conditionally-compiled parameters.
Key Changes:
- Updated
xlog_initto accept a 5th parameter (boolean flag) - Updated
vsdk_initto accept 2 additional parameters for file logging configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/factory/ctrlmf_version.c | Added 5th boolean parameter (false) to xlog_init call |
| src/ctrlm_main.cpp | Added 2 additional parameters to vsdk_init call for filename and file size configuration, initialized to NULL and 0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const char *filename = NULL; | ||
| uint32_t file_size_max = 0; | ||
| vsdk_init(true, filename, file_size_max); |
Copilot
AI
Nov 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intermediate variables filename and file_size_max are unnecessary. They are initialized with constant values and immediately passed to vsdk_init without any modification. Consider simplifying by passing the values directly:
vsdk_init(true, NULL, 0);This would eliminate the need for lines 484-485 and make the code more concise.
| const char *filename = NULL; | |
| uint32_t file_size_max = 0; | |
| vsdk_init(true, filename, file_size_max); | |
| vsdk_init(true, NULL, 0); |
No description provided.