RDKEMW-8929: Refactor base ipc class #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for change: Test Procedure: Risks: Signed-off-by: Kelvin Lu <Kelvin_Lu@comcast.com>
egalla204
previously approved these changes
Dec 11, 2025
There was a problem hiding this comment.
Pull request overview
This PR refactors the IPC (Inter-Process Communication) base class to consolidate common IARM functionality and eliminate code duplication. The refactoring moves broadcast event functions from individual IPC implementations into a base class template, making the code more maintainable and reusable across different IPC implementations.
Key Changes:
- Introduced
api_revision_member and associated getter/setter methods in the basectrlm_ipc_iarm_tclass - Converted
broadcast_iarm_eventfunctions to templated methods in the base class to support different event structure types - Consolidated duplicate
broadcast_eventstatic functions from voice IPC implementations into the base class
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ipc/ctrlm_ipc_iarm.h | Added api_revision management, templated broadcast_iarm_event functions, and broadcast_iarm_event_legacy method |
| src/ipc/ctrlm_ipc_iarm.cpp | Implemented api_revision getter/setter and broadcast_iarm_event_legacy; removed old broadcast_iarm_event implementation |
| src/voice/ipc/ctrlm_voice_ipc.h | Made ctrlm_voice_ipc_t inherit from ctrlm_ipc_iarm_t base class |
| src/voice/ipc/ctrlm_voice_ipc_iarm_thunder.cpp | Updated constructor to set api_revision, refactored to use base class methods, removed duplicate broadcast_event function |
| src/voice/ipc/ctrlm_voice_ipc_iarm_legacy.cpp | Updated to use broadcast_iarm_event_legacy from base class, removed duplicate broadcast_event function |
| src/ipc/ctrlm_rcp_ipc_iarm_thunder.cpp | Added api_revision initialization and updated broadcast_iarm_event calls to use template syntax |
| include/ctrlm_ipc_voice.h | Minor whitespace cleanup in comments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
egalla204
approved these changes
Dec 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change:
Test Procedure:
Risks: