RDKEMW-10107: Speaker volume level do not persist after reboot

[yeshwanth-nagaswamy]

https://ccp.sys.comcast.net/browse/RDKEMW-10107

[apatel859]

As this is local variable u can remove m_ prefix to avoid confusion

[Copilot]

Pull Request Overview

This PR fixes an issue where the speaker volume level does not persist after a device reboot. The solution removes the static cached variable m_volumeLevel and replaces it with runtime calls to dsGetAudioLevel() to retrieve the current audio level from the underlying system.

• Removed static variable m_volumeLevel that was caching volume level
• Modified _dsSetAudioDucking() to call dsGetAudioLevel() to get current volume instead of using cached value
• Updated setAudioDuckingAudioLevel() to retrieve volume dynamically when ducking is not in progress

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

If dsGetAudioLevel() fails, volumeLevel remains 0 and the function continues execution. This could result in incorrect volume calculations (e.g., setting volume to 0 during ducking). Consider either returning early on failure or using a fallback value to prevent potential volume loss.

Suggestion:

ret = dsGetAudioLevel (param->handle, &volumeLevel);
if (ret != dsERR_NONE) {
    INT_ERROR("%s failed dsGetAudioLevel\n",__FUNCTION__);
    IARM_BUS_Unlock(lock);
    return IARM_RESULT_INVALID_STATE;
}

Suggested change

	INT_ERROR("%s failed dsGetAudioLevel\n",__FUNCTION__);
	INT_ERROR("%s failed dsGetAudioLevel\n",__FUNCTION__);
	IARM_BUS_Unlock(lock);
	return IARM_RESULT_INVALID_STATE;

[Copilot]

If dsGetAudioLevel() fails, volume remains 0 but the function continues to set this value via dsSetAudioLevelFunc() at line 3220. This could incorrectly set the audio level to 0. Consider returning an error when dsGetAudioLevel() fails to prevent incorrect volume settings.

Suggestion:

dsError_t ret = dsGetAudioLevel (handle, &volume);
if (ret != dsERR_NONE) {
    INT_ERROR("%s failed dsGetAudioLevel\n",__FUNCTION__);
    return IARM_RESULT_INVALID_STATE;
}

Suggested change

	INT_ERROR("%s dsGetAudioLevel\n",__FUNCTION__);
	}
	INT_DEBUG("%s: audio level %f\n", __FUNCTION__, volume);
	}
	if (dsSetAudioLevelFunc == 0)
	{
	INT_ERROR("%s failed dsGetAudioLevel\n",__FUNCTION__);
	return IARM_RESULT_INVALID_STATE;
	}
	INT_DEBUG("%s: audio level %f\n", __FUNCTION__, volume);
	}
	if (dsSetAudioLevelFunc == 0)