fix: Align naming convention, use Transport v25#11
Conversation
There was a problem hiding this comment.
Pull request overview
This PR performs a maintenance update that aligns naming conventions and upgrades to Transport v25. The changes include correcting the transport library name from "firebolt-native-transport" to "firebolt-cpp-transport", fixing spelling errors in tests and documentation, cleaning up unused header includes, standardizing documentation formatting, and improving the build system to separate development and production builds.
- Upgraded transport library from v1.0.0-next.23 to v1.0.0-next.25 with corrected naming
- Fixed spelling errors in test names, comments, and API documentation
- Removed unused header includes and aligned documentation formatting across multiple interface files
Reviewed changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.transport.version |
Updated transport version from 1.0.0-next.23 to 1.0.0-next.25 |
CMakeLists.txt |
Corrected transport library name to firebolt-cpp-transport and added SHA256 hash for security |
.github/Dockerfile |
Updated transport library URLs to use correct firebolt-cpp-transport naming |
build.sh |
Added support for separate build-dev directory for test builds and improved cleanup logic |
.gitignore |
Added pattern to ignore all build-* directories |
test/CMakeLists.txt |
Added DISCOVERY_MODE PRE_TEST to both unit and component test discovery |
test/utils.cpp |
Made EventWaitTime type more explicit using std::chrono::seconds |
test/unit/deviceTest.cpp |
Fixed spelling in test name from GetClassBadRespons_Test to GetClassBadResponse_Test |
test/component/deviceTest.cpp |
Corrected spelling of "recived" to "received" in two test output messages |
include/firebolt/firebolt.h |
Fixed spelling of "Accessibiilty" to "Accessibility" and cleaned up malformed documentation |
include/firebolt/stats.h |
Removed unused includes (functional, optional, string, vector) and cleaned documentation |
include/firebolt/presentation.h |
Aligned parameter documentation formatting |
include/firebolt/localization.h |
Removed unused optional include and standardized documentation formatting |
include/firebolt/lifecycle.h |
Removed unused string include and aligned parameter documentation |
include/firebolt/display.h |
Removed unused includes (functional, optional, string, vector) |
include/firebolt/device.h |
Removed unused includes (functional, optional, vector) |
include/firebolt/advertising.h |
Removed unused includes (functional, vector) |
include/firebolt/accessibility.h |
Removed unused optional include and aligned parameter documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| && dir="firebolt-native-transport-${DEPS_TRANSPORT_V}" \ | ||
| && i=0 && while ! curl -sL https://github.com/rdkcentral/firebolt-native-transport/releases/download/v${DEPS_TRANSPORT_V}/firebolt-native-transport-${DEPS_TRANSPORT_V}.tar.gz | tar xzf - ; do test "$i" -eq 5 && exit 1; i=$((i+1)); sleep 1; done \ | ||
| && dir="firebolt-cpp-transport-${DEPS_TRANSPORT_V}" \ | ||
| && i=0 && while ! curl -sL https://github.com/rdkcentral/firebolt-cpp-transport/releases/download/v${DEPS_TRANSPORT_V}/firebolt-cpp-transport-${DEPS_TRANSPORT_V}.tar.gz | tar xzf - ; do test "$i" -eq 5 && exit 1; i=$((i+1)); sleep 1; done \ |
There was a problem hiding this comment.
This Docker build step downloads and extracts a remote tarball via curl -sL ... | tar xzf - without any integrity verification, which enables a supply chain attack if the GitHub release, DNS, or TLS chain is ever compromised. An attacker who controls or tampers with that archive could execute arbitrary code during the image build and poison the resulting build environment. Please pin this dependency to an immutable reference and verify the archive using a strong checksum or signature before extracting and building it.
|
🎉 This PR is included in version 0.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.