Skip to content

Conversation

@tomasz-blasz
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings January 23, 2026 18:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR shortens the names of several CMake-built executables and aligns the CI workflow with those new names.

Changes:

  • Rename unit test executable target from FireboltClientUnitTests to utApp and component test executable from FireboltClientComponentTests to ctApp in test/CMakeLists.txt.
  • Rename demo executable target from FireboltCoreDemo (via DEMO_APP) to demoApp in demo/CMakeLists.txt.
  • Update GitHub Actions CI workflow to use the new unit and component test executable names (utApp, ctApp) when chmod-ing and invoking tests.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
test/CMakeLists.txt Updates unit and component test executable target names and keeps all CMake usage consistent with the new names.
demo/CMakeLists.txt Renames the demo executable target to demoApp, affecting the installed and built binary name.
.github/workflows/ci.yml Adjusts CI steps to chmod and pass the new test executable names (utApp, ctApp) into the Docker-based test runs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tomasz-blasz tomasz-blasz force-pushed the topic/ci-simplify-execs branch from e0e707c to b15cca8 Compare January 23, 2026 18:26
@tomasz-blasz tomasz-blasz merged commit 126dfed into main Jan 26, 2026
11 checks passed
@tomasz-blasz tomasz-blasz deleted the topic/ci-simplify-execs branch January 26, 2026 09:01
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2026
@tomasz-blasz
Copy link
Contributor Author

🎉 This PR is included in version 0.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants