build: Rename headers with internal json wrappers#47
Merged
tomasz-blasz merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
tomasz-blasz
force-pushed
the
topic/rename-internals
branch
from
ac50c26 to
ce78575
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors the internal JSON wrapper headers by renaming them from the jsondata_* naming pattern to a more organized json_types/ directory structure. The changes improve code organization by consolidating all JSON serialization/deserialization wrappers into a single directory with cleaner, module-based naming.
Changes:
- Renamed JSON wrapper headers from
jsondata_*.htojson_types/*.h(e.g.,jsondata_device_types.h→json_types/device.h) - Updated all include statements across source and test files to use the new header paths
- Removed redundant include directory from CMakeLists.txt since json_types is now relative to src/
Reviewed changes
Copilot reviewed 15 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/deviceTest.cpp | Updated include from jsondata_device_types.h to json_types/device.h |
| test/component/deviceTest.cpp | Updated include from jsondata_device_types.h to json_types/device.h |
| test/api_test_app/apis/lifecycleDemo.cpp | Updated include from jsondata_lifecycle_types.h to json_types/lifecycle.h |
| test/api_test_app/apis/discoveryDemo.cpp | Updated include from jsondata_common.h to json_types/common.h |
| test/api_test_app/apis/deviceDemo.cpp | Updated include from jsondata_device_types.h to json_types/device.h |
| src/texttospeech_impl.cpp | Updated include from jsondata_texttospeech_types.h to json_types/texttospeech.h |
| src/stats_impl.cpp | Updated include from jsondata_stats_types.h to json_types/stats.h |
| src/metrics_impl.cpp | Updated includes from jsondata_common.h and jsondata_metrics_types.h to json_types/common.h and json_types/metrics.h |
| src/lifecycle_impl.cpp | Updated include from jsondata_lifecycle_types.h to json_types/lifecycle.h |
| src/json_types/texttospeech.h | New JSON wrapper header for TextToSpeech module with enum and class definitions |
| src/json_types/stats.h | New JSON wrapper header for Stats module |
| src/json_types/metrics.h | New JSON wrapper header for Metrics module |
| src/json_types/lifecycle.h | New JSON wrapper header for Lifecycle module |
| src/json_types/display.h | New JSON wrapper header for Display module |
| src/json_types/device.h | New JSON wrapper header for Device module |
| src/json_types/common.h | New JSON wrapper header for common types |
| src/json_types/advertising.h | New JSON wrapper header for Advertising module |
| src/json_types/accessibility.h | New JSON wrapper header for Accessibility module |
| src/display_impl.cpp | Updated include from jsondata_display_types.h to json_types/display.h |
| src/discovery_impl.cpp | Updated include from jsondata_common.h to json_types/common.h |
| src/device_impl.cpp | Updated include from jsondata_device_types.h to json_types/device.h |
| src/advertising_impl.cpp | Updated include from jsondata_advertising_types.h to json_types/advertising.h |
| src/accessibility_impl.cpp | Updated include from jsondata_accessibility_types.h to json_types/accessibility.h |
| src/CMakeLists.txt | Removed redundant json_types include directory path |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vladimir-rangelov
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.